Fix for #815: restore type confidence of private trait method reference

groovy · Feb 19, 2019 · 9bd9231 · 9bd9231
1 parent 97cc68b
commit 9bd9231
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/...ore.tests.builder/src/org/eclipse/jdt/core/groovy/tests/search/TraitInferencingTests.java b/...ore.tests.builder/src/org/eclipse/jdt/core/groovy/tests/search/TraitInferencingTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2009-2018 the original author or authors.
+ * Copyright 2009-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -91,6 +91,60 @@ public void testPrivateMethod() {
         assertExprType(source, "check", "java.lang.Boolean");
     }
 
+    @Test
+    public void testPrivateMethod2() {
+        String contents =
+            "trait A {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "trait B {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "class C implements A, B {\n" +
+            "  void something() {\n" +
+            "    method()\n" +
+            "  }\n" +
+            "}";
+        assertDeclType(contents, "method", "A");
+        assertExprType(contents, "method", "java.lang.Void");
+    }
+
+    @Test
+    public void testPrivateMethod3() {
+        String contents =
+            "trait A {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "trait B {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "class C implements A, B {\n" +
+            "  void something() {\n" +
+            "    A.super.method()\n" +
+            "  }\n" +
+            "}";
+        assertDeclType(contents, "method", "A$Trait$Helper");
+        assertExprType(contents, "method", "java.lang.Void");
+    }
+
+    @Test
+    public void testPrivateMethod4() {
+        String contents =
+            "trait A {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "trait B {\n" +
+            "  private void method() {}\n" +
+            "}\n" +
+            "class C implements A, B {\n" +
+            "  void something() {\n" +
+            "    B.super.method()\n" +
+            "  }\n" +
+            "}";
+        assertDeclType(contents, "method", "B$Trait$Helper");
+        assertExprType(contents, "method", "java.lang.Void");
+    }
+
     @Test // https://issues.apache.org/jira/browse/GROOVY-8854
     public void testPrivateStaticMethod() {
         String source =

diff --git a/base/org.eclipse.jdt.groovy.core/src/org/eclipse/jdt/groovy/search/SimpleTypeLookup.java b/base/org.eclipse.jdt.groovy.core/src/org/eclipse/jdt/groovy/search/SimpleTypeLookup.java
@@ -954,7 +954,7 @@ protected static boolean isCompatible(final AnnotatedNode declaration, final boo
     }
 
     protected static boolean isNotThisOrOuterClass(final ClassNode thisType, final ClassNode declaringClass) {
-        return (!thisType.equals(declaringClass) && !thisType.getOuterClasses().contains(declaringClass));
+        return (!thisType.equals(declaringClass) && !thisType.getOuterClasses().contains(declaringClass) && !(implementsTrait(thisType) && thisType.implementsInterface(declaringClass)));
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         protected static boolean isNotThisOrOuterClass(final ClassNode thisType, final ClassNode declaringClass) {
-            return (!thisType.equals(declaringClass) && !thisType.getOuterClasses().contains(declaringClass));
+            return (!thisType.equals(declaringClass) && !thisType.getOuterClasses().contains(declaringClass) && !(implementsTrait(thisType) && thisType.implementsInterface(declaringClass)));
         }
         /**
@@ Expand Down @@