fix grab support

#1166
groovy · Sep 29, 2020 · e6d3b29 · e6d3b29
1 parent ae81a3d
commit e6d3b29
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/base/org.codehaus.groovy30/src/groovy/grape/GrapeIvy.groovy b/base/org.codehaus.groovy30/src/groovy/grape/GrapeIvy.groovy
@@ -177,9 +177,11 @@ class GrapeIvy implements GrapeEngine {
             if (!isValidTargetClassLoader(loader)) {
                 loader = GrapeIvy.getClass().getClassLoader()
             }*/
+            /* GRECLIPSE edit -- removing this only affects the GrapeIvy used during compilation, where the ClassLoader doesn't matter
             if (!isValidTargetClassLoader(loader)) {
                 throw new RuntimeException('No suitable ClassLoader found for grab')
             }
+            */
         }
         loader
     }

diff --git a/...s.groovy.eclipse.tests/src/org/codehaus/groovy/eclipse/test/GroovyEclipseTestSuite.groovy b/...s.groovy.eclipse.tests/src/org/codehaus/groovy/eclipse/test/GroovyEclipseTestSuite.groovy
@@ -91,7 +91,7 @@ abstract class GroovyEclipseTestSuite {
 
     @After
     final void tearDownTestCase() {
-        GroovyPlugin.default.activeWorkbenchWindow.activePage.closeAllEditors(false)
+        GroovyPlugin.default.activeWorkbenchWindow?.activePage?.closeAllEditors(false)
         testProject.deleteWorkingCopies()
 
         testProject.project.build(IncrementalProjectBuilder.CLEAN_BUILD, null)

diff --git a/....tests/src/org/codehaus/groovy/eclipse/test/launch/GroovyScriptLaunchShortcutTests.groovy b/....tests/src/org/codehaus/groovy/eclipse/test/launch/GroovyScriptLaunchShortcutTests.groovy
@@ -276,10 +276,8 @@ final class GroovyScriptLaunchShortcutTests extends GroovyEclipseTestSuite {
     @Test // https://github.com/groovy/groovy-eclipse/issues/779
     void testScriptLaunch13() {
         def unit = addGroovySource('''\
-            |@Grapes([
-            |  @GrabConfig(systemClassLoader=true),
-            |  @Grab('mysql:mysql-connector-java:5.1.6')
-            |])
+            |@GrabConfig(systemClassLoader=true)
+            |@Grab('mysql:mysql-connector-java:5.1.6')
             |def xxx
             |
             |println "Why won't this run?"