Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support asynchronous computation of content assist proposals #1123

Closed
CrushaKRool opened this issue Jun 3, 2020 · 2 comments
Closed

Support asynchronous computation of content assist proposals #1123

CrushaKRool opened this issue Jun 3, 2020 · 2 comments
Assignees
Milestone

Comments

@CrushaKRool
Copy link

Eclipse introduced a flag in 4.14 that lets code completion providers indicate whether they require to run in the UI thread or can be computed in the background, to provide a more fluent user experience when hitting the content assist key.

However, it seems like the Groovy Eclipse proposals are currently preventing this feature from being used in the IDE.
GroovyEclipseCodeCompletion

Perhaps it wouldn't take much to make the computation from this plugin async-compatible as well?

@eric-milles
Copy link
Member

ready to test

@CrushaKRool
Copy link
Author

Looks good to me. No longer prevents that option from being enabled in the settings and couldn't notice any obvious issues when opening Content Assist.

eric-milles added a commit that referenced this issue Jul 30, 2020
evaluateExpression gets its ClassLoader from ProcessingUnit; in the
fork-join pool, the thread context loader is not good for Groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants