Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system-property-based filtering of global AST transforms #814

Closed
eric-milles opened this issue Feb 16, 2019 · 0 comments
Closed

Remove system-property-based filtering of global AST transforms #814

eric-milles opened this issue Feb 16, 2019 · 0 comments
Assignees
@eric-milles
Labels
enhancement
Milestone
v3.5.0

Comments

@eric-milles
Copy link
Member

eric-milles commented Feb 16, 2019 •
edited
Loading

Replace system property greclipse.globalTransformsInReconcile used in ASTTransformationVisitor with the standard compiler configuration option org.codehaus.groovy.control.CompilerConfiguration setDisabledGlobalASTTransformations(Set<String>).
@eric-milles eric-milles added this to the v3.4.0 milestone Mar 18, 2019
@eric-milles eric-milles removed this from the v3.4.0 milestone May 22, 2019
@eric-milles eric-milles mentioned this issue Jun 24, 2019
Closed
@eric-milles eric-milles added this to the v3.5.0 milestone Jun 26, 2019
@eric-milles eric-milles self-assigned this Jul 1, 2019
eric-milles added a commit that referenced this issue Jul 1, 2019
@eric-milles
Fix for #814: enable global xforms (except Spock) during reconcile
04673d9 
Global xforms disabled for:
- index
- find JUnit tests
- open in editor (aka become working copy)
- select in explorer (aka test for extract class refactor)

Global xforms enabled for:
- compile
- reconcile
- resolve source reference
- code minings (aka search)

Note: #812 is disabled until Spock xform is run as part of reconcile

Note: Scripts with @grab will now open in editor immediately and the
grabs are processed asynchronously as part of reconcile operation

Note: Global xforms that run during Conversion compiler phase are applied even if disabled by CompilerConfiguration setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-milles eric-milles

Labels
enhancement
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@eric-milles