Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded ENV['TRAVIS'] from spec #341

Merged
merged 1 commit into from
Feb 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions spec/parallel_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ def cpus
end

it 'does not leave processes behind while running' do
skip if ENV['TRAVIS'] # this randomly fails on travis all the time :(
ruby("spec/cases/closes_processes_at_runtime.rb").gsub(/.* deprecated; use BigDecimal.*\n/, '').should == 'OK'
end

Expand Down Expand Up @@ -510,7 +509,6 @@ def cpus
end

it 'sets Parallel.worker_number when run with isolation' do
skip if ENV['TRAVIS'] # this randomly hangs on travis
out = ruby("spec/cases/map_worker_number_isolation.rb")
out.should == "0,1\nOK"
end
Expand Down Expand Up @@ -603,7 +601,7 @@ def cpus
end

it "does not slow down with lots of GC work in threads" do
Benchmark.realtime { ruby("spec/cases/no_gc_with_each.rb 2>&1") }.should <= (ENV["TRAVIS"] ? 15 : 10)
Benchmark.realtime { ruby("spec/cases/no_gc_with_each.rb 2>&1") }.should <= 10
end

it "can modify in-place" do
Expand Down
Loading