Ensure not to use old concurrent-ruby
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some users encounter with a negative values issue of `Concurrent.available_processor_count`. grosser#349 (comment) To avoid the issue, this PR ensure not to use old `concurrent-ruby`. This PR also removes considering of `NoMethodError` because we can assume to use `available_processor_count` always.
eregon
reviewed
Aug 16, 2024
| @@ -697,9 +697,10 @@ def instrument_start(item, index, options) | |||
| end | |||
|
|
|||
| def available_processor_count | |||
| gem 'concurrent-ruby', '>= 1.3.4' | |||
There was a problem hiding this comment.
What does this raise if ran under bundle exec with an older concurrent-ruby?
There was a problem hiding this comment.
Gem::LoadError will be raised. Gem::LoadError is a descendant of LoadError. So we can rescue it in
Line 702 in ab06d9e
|
thx! v1.26.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some users encounter with a negative values issue of
Concurrent.available_processor_count.#349 (comment)
To avoid the issue, this PR ensure not to use old
concurrent-ruby. This PR also removes considering ofNoMethodErrorbecause we can assume to useavailable_processor_countalways.