Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large displays painfully slow #5

Open
tfmorris opened this issue Apr 27, 2016 · 1 comment
Open

Large displays painfully slow #5

tfmorris opened this issue Apr 27, 2016 · 1 comment

Comments

@tfmorris
Copy link

Basically any plot longer than 3 days is unusable, it least with Chrome on Mac. Part of the problem may be the increasing price volatility which creates more data to be plotted, but I suspected it could be related to this bug as well: novus/nvd3#691

Perhaps updating to more modern versions of nvd3 and d3 would fix, or at least improve, things as an easy fix. Also, it seems like the Voronoi feature is pretty heavy-weight, so perhaps an option could be provided to turn it off chart.useVoronoi(false).

@tfmorris
Copy link
Author

I looked into this a little bit more and it looks like AdBlockPro was part of the problem, but there's definitely a problem with the Voronoi diagram.

One test (8 days, I think) broke down as:
14 sec. - fetch from server
2 sec. - render chart
6 sec. - update interactive layer (Voronoi)
11 sec. - ABP filter processing (!!)

But turning off ABP and going up to 30 days showed there's some kind of O(n^2) action going on with the Voronio diagram:
20 sec. - fetch
6 sec. - render
3 sec. - D3 timer flush (??)
4.9 min - update interactive layer (!!) - 4.8 min. of which is in d3.geom.voronoi

The Voronoi based interaction layer is a nice UX addition, but I'd happily give it up to get back 5 minutes every time I wanted to plot a chart.

tfmorris added a commit to tfmorris/ec2price that referenced this issue Apr 27, 2016
While nice from a UX point of view, it's a CPU & memory hog for large numbers. With it off, hover still works, but only when you're directly over the point, rather than in the neighborhood (Voronoi region).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant