Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use tlv to send the whole message without splitting it #88

Closed
aurelien-baudet opened this issue Nov 29, 2019 · 0 comments
Closed

Allow to use tlv to send the whole message without splitting it #88

aurelien-baudet opened this issue Nov 29, 2019 · 0 comments
Labels
feature P3 SMS
Milestone
Release v3.0.0

Comments

@aurelien-baudet
Copy link
Member

Some services accept to receive the full message in a tlv parameter.
The service then handles the split of the message itself.
Add an option to allow to use tlv parameter.
It can also be useful when splitting is disabled.

Both splitting and tlv may be used together for some services so if both are enabled be the developer, don't prevent it.
@aurelien-baudet aurelien-baudet added this to the Release v3.0.0 milestone Nov 29, 2019
aurelien-baudet added a commit that referenced this issue Dec 21, 2019
@aurelien-baudet
feat(split) Automatically split SMS in parts according to encoding
c06f80e 
- Automatically guess encoder that can encode properly the message
- Split according to encoder (either 160/153 characters for GSM 7-bit, 140/134 characters for GSM 8-bit or 70/67 characters for UCS-2)
- fixes #69
- Support TLV message_payload optional parameter (#88)
- Add service configurer dedicated to SMSGlobal
- Need to add different configuration phases in order to be able to override some values for a particular service provider (like SMSGlobal)
aurelien-baudet added a commit that referenced this issue Dec 21, 2019
@aurelien-baudet
feat(split) Automatically split SMS in parts according to encoding
3123181 
- Automatically guess encoder that can encode properly the message
- Split according to encoder (either 160/153 characters for GSM 7-bit, 140/134 characters for GSM 8-bit or 70/67 characters for UCS-2)
- fixes #69
- Support TLV message_payload optional parameter (#88)
- Add service configurer dedicated to SMSGlobal
- Need to add different configuration phases in order to be able to override some values for a particular service provider (like SMSGlobal)
aurelien-baudet added a commit that referenced this issue Dec 21, 2019
@aurelien-baudet
feat(split) Automatically split SMS in parts according to encoding
753aae9 
- Automatically guess encoder that can encode properly the message
- Split according to encoder (either 160/153 characters for GSM 7-bit, 140/134 characters for GSM 8-bit or 70/67 characters for UCS-2)
- fixes #69
- Support TLV message_payload optional parameter (#88)
- Add service configurer dedicated to SMSGlobal
- Need to add different configuration phases in order to be able to override some values for a particular service provider (like SMSGlobal)
aurelien-baudet added a commit that referenced this issue Dec 21, 2019
@aurelien-baudet
feat(split) Automatically split SMS in parts according to encoding
6ea81a7 
- Automatically guess encoder that can encode properly the message
- Split according to encoder (either 160/153 characters for GSM 7-bit, 140/134 characters for GSM 8-bit or 70/67 characters for UCS-2)
- fixes #69
- Support TLV message_payload optional parameter (#88)
- Add service configurer dedicated to SMSGlobal
- Need to add different configuration phases in order to be able to override some values for a particular service provider (like SMSGlobal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature P3 SMS
Projects
None yet
Milestone
Release v3.0.0
Development

No branches or pull requests
1 participant
@aurelien-baudet