Delete old videos in hub before downloading a new video #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the new tests failed because the video_ouput directory doesn't exist. Should this directory be created under : /src/test/resources/fixtures/video_output ? Or somewhere else? This is the test : testDeleteOldMovies(com.groupon.seleniumgridextras.videorecording.VideoRecorderCallableTest |
|
You are right, now video_output directory is created if it does not exist. |
smccarthy
added a commit
that referenced
this pull request
Oct 9, 2015
Delete old videos in hub before downloading a new video
|
All tests passed. Merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete old videos in hub before downloading a new video from any node, when there is more than 'videos_to_keep' videos in hub.
If hub is configured with "videos_to_keep": "0", the video will not be downloaded.
Fix this issue: #92