Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup fix & code cleanup #3

Merged
merged 4 commits into from
Jul 17, 2019
Merged

Conversation

dbushong
Copy link
Member

  • fix: verifySetup sub-invocations
  • chore: npm audit fix
  • refactor: typecheck the lib code

mostly about the first fix commit - the typechecking refactor got a little out-of-hand


This PR was started by: git wf pr

addresses:

```
🚢💥 TypeError: Cannot read property 'branch' of undefined
    at verifySetup (/Users/dbushong/repo/public/git-workflow/lib/setup.js:58:30)
    at verifySetup (/Users/dbushong/repo/public/git-workflow/lib/setup.js:107:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)
```
Copy link
Contributor

@markowsiak markowsiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markowsiak markowsiak merged commit e94b0c8 into master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants