Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect the presence of a PULL_REQUEST_TEMPALTE.md #7

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

markowsiak
Copy link
Contributor

Description

These changes ensure that if a PULL_REQUEST_TEMPLATE.md file is present in the repository, it's contents are respected and added to the PR (by default) upon the execution of git wf pr.

Additionally, it adds a -i option to the command to ignore the template if so desired.

Also

Hey @dbushong @aotarola @erothman-groupon 👋
I hope you're all doing well 👍

Copy link

@aaarichter aaarichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hey @markowsiak hope you are doing good too? Thanks for submitting this change.

@markowsiak
Copy link
Contributor Author

Thanks @aaarichter! Things are good here, and we're all hoping for a better tomorrow 😷 👍
I hope you're doing well too! 😸 🦦

BTW, I got removed from the org so I don't have merge any longer 🤷
I'm definitely happy we open-sourced this tool though. So useful!

Copy link
Member

@aotarola aotarola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 💚

@aotarola aotarola merged commit 66d5eb0 into groupon:master Jun 16, 2020
@markowsiak
Copy link
Contributor Author

Thanks @aotarola 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants