Skip to content

Conversation

barrutko
Copy link

@barrutko barrutko commented Aug 4, 2025

Changes in the PR

  1. Folders renamed:

    • avalanche-fork to grove-avalanche-fork since tests use Grove addresses
    • base-fork to spark-base-fork since tests use Spark addresses
    • mainnet-fork to spark-mainnet-fork since tests use Spark addresses
  2. New test folder introduced:
    grove-mainnet-fork - a folder with mainnet fork tests, using Grove addresses. grove-mainnet-fork/ForkTestBase.t.sol is almost an exact copy of spark-mainnet-fork/ForkTestBase.t.sol. The only differences are:

    • Usage of Grove addresses instead of Spark addresses
    • Base references were replaced with Avalanche references
  3. Multiple test files moved from spark-mainnet-fork to grove-mainnet-fork. In order to make them compatible with the new test base, SPARK_PROXY reference was replaced with GROVE_PROXY reference

  4. spark-address-registry import in MainnetController.sol was swapped to grove-address-registry

@barrutko barrutko requested a review from kevinlichan August 4, 2025 16:56
@barrutko barrutko self-assigned this Aug 4, 2025
* feat: use grove-address-registry in MainnetController

* refactor: use avalanche instead of base in the grove test base
Copy link

github-actions bot commented Aug 4, 2025

Coverage after merging migrate-tests into dev will be

99.83%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
deploy
   ControllerDeploy.sol100%100%100%100%
   ForeignControllerInit.sol100%100%100%100%
   MainnetControllerInit.sol97.30%93.33%100%100%144, 84
src
   ALMProxy.sol100%100%100%100%
   ForeignController.sol98.79%91.67%100%99.17%272–273
   MainnetController.sol100%100%100%100%
   RateLimitHelpers.sol100%100%100%100%
   RateLimits.sol100%100%100%100%
src/libraries
   CCTPLib.sol100%100%100%100%
   CentrifugeLib.sol100%100%100%100%
   CurveLib.sol100%100%100%100%
   PSMLib.sol100%100%100%100%

Copy link

@kevinlichan kevinlichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. These changes to updated the the test suite from Spark contracts to Grove contracts and updating to the grove-address-registry looks in good form to me.

@kevinlichan kevinlichan merged commit 1e12d82 into dev Aug 5, 2025
3 checks passed
barrutko added a commit that referenced this pull request Aug 11, 2025
* feat: reintroduce Centrifuge controller updates; remove Superstate integration (#21)

* feat: add Centrifuge to ForeignController

* Revert "feat: bring back superstate & maple; remove centrifuge crosschain transfers (#16)"

This reverts commit 71fd906.

* refactor: add minor refactorings

* feat: extract Lib, bring back Maple

* fix: remove unused import

* chore: remove irrelevant change

* refactor: reorder

* fix: remove redundant imports

* test: migrate tests to use GROVE_PROXY as admin (#22)

* chore: update address registry

* refactor: rename folders

* test: start grove mainnet fork tests

* test: migrate tests to use GROVE_PROXY

* feat: use grove-address-registry in MainnetController (#23)

* feat: use grove-address-registry in MainnetController

* refactor: use avalanche instead of base in the grove test base

* fix: minor issues (#25)

* fix: correct error message

* fix: use explicit imports

* fix: remove unused import

* refactor: merge ICentrifugeToken and ICentrifugeV3VaultLike interfaces (#28)

* feat: add centrifuge recipient to scripts (#30)

* feat: add centrifuge recipient to foreign controller init

* feat: add centrifuge mint recipients to mainnet init

* feat: hardcode remoteExtraGasLimit to 0 (#27)

* feat: deploy updated controllers (#31)
barrutko added a commit that referenced this pull request Aug 22, 2025
* feat: add v1.6.0 changes (#32)

* feat: reintroduce Centrifuge controller updates; remove Superstate integration (#21)

* feat: add Centrifuge to ForeignController

* Revert "feat: bring back superstate & maple; remove centrifuge crosschain transfers (#16)"

This reverts commit 71fd906.

* refactor: add minor refactorings

* feat: extract Lib, bring back Maple

* fix: remove unused import

* chore: remove irrelevant change

* refactor: reorder

* fix: remove redundant imports

* test: migrate tests to use GROVE_PROXY as admin (#22)

* chore: update address registry

* refactor: rename folders

* test: start grove mainnet fork tests

* test: migrate tests to use GROVE_PROXY

* feat: use grove-address-registry in MainnetController (#23)

* feat: use grove-address-registry in MainnetController

* refactor: use avalanche instead of base in the grove test base

* fix: minor issues (#25)

* fix: correct error message

* fix: use explicit imports

* fix: remove unused import

* refactor: merge ICentrifugeToken and ICentrifugeV3VaultLike interfaces (#28)

* feat: add centrifuge recipient to scripts (#30)

* feat: add centrifuge recipient to foreign controller init

* feat: add centrifuge mint recipients to mainnet init

* feat: hardcode remoteExtraGasLimit to 0 (#27)

* feat: deploy updated controllers (#31)

* feat: add v1.6.0 Cantina audit (#33)

* feat: add v1.6.0 ChainSecurity audit (#34)
@barrutko barrutko deleted the migrate-tests branch August 22, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants