Security System: Turn off the zones together when the alarm is disarmed

[paolotremadio]

Scenario: the alarm is set to "Away". One of the zones is triggered by one sensor. The alarm is now "Alarm". Turn the alarm to Off. Turn the alarm to "Away" again will automatically go to "Alarm" because one or more zones are still activated. We should give the option to automatically turn off / reset the zones when turning off the alarm.

[Darko2]

I got the same issue of alarm turning right back on but i dont use zones. I suspect the “Alarm triggered” switch should be reset too.

[paolotremadio]

@Darko2 can you please list the steps to reproduce? so I can have a look into it.

[Darko2]

I ran some simulations to try to replicate the issue.
I tried to repeat the steps manually, my automations would ordinarily do, and this is what I got:

• security system state = disarmed
• all security system switches to off (stay, away, night, triggered)
• alarm triggered switch to on
• arm away switch (or any other arm switch) to on
  Alarm is immediately triggered.

Alarm is not triggered if the alarm triggered switch is left on while in arm state:

• security system state = arm away
• alarm triggered switch to on (alarm is triggered)
• disarm alarm
• arm away switch to on

I get now that an error in my automation behavior is the root cause of the problem, setting the trigger to on even when the alarm was disarmed should not happen.

Still, If alarm is disarmed (either with turning off the arm switches, or with setting the system state to disarm) the alarm triggered switch should be reset to off and if the alarm system state is changed from disarm to arm, the alarm triggered switch should first be set to off then the system should be armed.

Hope this helps. Thanks!

[paolotremadio]

The reason of this PR is exactly that: fixing automations. I had an automation that was turning off the "alarm" switches when turning off the alarm. It worked but re-enabling the alarm was going straight in "Alarm" mode. The reason is: a race condition in the plugin. You can run a single change at the time, because the plugin is trying to store the settings on disc (async). If you change two or more accessories at once (with an automation), some will not be stored in the internal state and the UI will be out of sync. This PR solves my issue to start. I would ask @grover to think about a long term solution :)