Fix some rust FFI #319
Merged
Fix some rust FFI #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust str is not null terminated Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
size and tftype must be mutable CString does not allow multiple nul bytes inside (this causes panic). Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
What indexing? |
|
Sorry :) wrong comment on wrong GitHub issue :). Please discard. |
|
gentle ping @grovesNL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered and verified on servo/servo#33918
as *casts are dangerous. Each commit is standalone and documented.