Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for asyncio based sticky bucketing, caching and tracking #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds support for asyncio based sticky bucketing, caching and tracking #29

wants to merge 2 commits into from

Conversation

palle-k
Copy link

@palle-k palle-k commented Feb 10, 2025 •
edited
Loading

This PR adds support for AsyncIO based sticky bucketing, caching and tracking.

To do so, it introduces an AsyncGrowthBook class (and corresponding AbstractAsyncStickyBucketService and AbstractAsyncFeatureCache classes).

Addresses #28

@vazarkevych
Copy link
Collaborator

Hi, @palle-k. Could you please fix the conflicts on the branch?

@palle-k
Merge branch 'main' into feat/asyncio
cf10566 
# Conflicts:
#	growthbook/growthbook.py
#	requirements_dev.txt
#	setup.py
#	tests/test_growthbook.py
@palle-k
Copy link
Author

palle-k commented Feb 13, 2025

@vazarkevych updated.

Haven't addressed the GrowthBookClient. It would probably be ideal to completely separate async and non-async implementations here, meaning that there's a GrowthBookClient with no async methods and an AsyncGrowthBookClient with async methods - same for GrowthBook and AsyncGrowthBook.

That would introduce more breaking changes though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palle-k @vazarkevych