-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#293 Ambiguous import issues when pinning grpc to <v1.30 #377
Comments
So we're depending transitively on bleeding edge grpc because we import the examples, which is its own module, which imports bleeding edge grpc? What a mess. Sounds like we should remove whatever example import we're depending on. Could you help get that done? |
drewwells
added a commit
to drewwells/go-grpc-middleware
that referenced
this issue
Jan 16, 2021
Refactors tests code to use local protobufs to avoid importing grpc/examples. This package uses bleeding edge grpc forcing dependent packages to import the latest grpc. fixes grpc-ecosystem#377
drewwells
added a commit
to drewwells/go-grpc-middleware
that referenced
this issue
Jan 16, 2021
Refactors test code to use local protobufs instead of importing grpc/examples. examples package uses bleeding edge grpc forcing the pulling of bleeding edge grpc fixes grpc-ecosystem#377
bwplotka
pushed a commit
that referenced
this issue
Jan 17, 2021
Refactors test code to use local protobufs instead of importing grpc/examples. examples package uses bleeding edge grpc forcing the pulling of bleeding edge grpc fixes #377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
google.golang.org/grpc v1.30+ broke a lot of contracts. As a result, we have been unable to upgrade to it and are stuck on v1.29.1. I'm seeing issues importing go-grpc-middleware, after some digging the issues are related to these changes #293. The test example is using google.golang.org/grpc/examples which imports bleeding edge grpc so we can not import it.
Could we stand up our own example proto to perform these simple tests? It will make this project more portable and support us poor saps unable to upgrade grpc.
Here's the error from
go mod tidy
Related #293
The text was updated successfully, but these errors were encountered: