-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Move metautils
to it's own package
#392
Comments
I think this is written on top of gRPC metadata? It should still be relevant in that case. |
It is indeed. Cool, let's move it out of utils then! |
Hi @bwplotka and @johanbrandhorst, I'd like to work on this issue. Just to confirm the metautils needs to be moved outside utils to the root and the references need to be updated right? |
Correct, just while you are doing this, can you just double check if all method names, comments make sense too? Would be nice to clean this before v2 release (while we can) 🤗 Also some better package name might be needed. The Thanks! |
Oh, and make sure you to start from |
You need to rebase your branch and start working on top of the current changes. |
- Move util/metautils to root-level package metadata - Rename NiceMD to MD, which is a wrapper for grpc/metadata.MD
- Move util/metautils to root-level package metadata - Rename NiceMD to MD, which is a wrapper for grpc/metadata.MD
Fixed by #474 |
This is the package that allows to pass things across gRPC peers. You mention @johanbrandhorst some other methods for this 🤔 Is there something or should we maintain it here?
The text was updated successfully, but these errors were encountered: