Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any docs about using github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus in middleware v2 #558

Open
wrapupc opened this issue Apr 11, 2023 · 3 comments
Labels

Comments

@wrapupc
Copy link

wrapupc commented Apr 11, 2023

Api in github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus is quite different from https://github.com/grpc-ecosystem/go-grpc-prometheus, and i didn't find any guidance of how to use it. Is is still in progress?

@bwplotka
Copy link
Collaborator

No, it's ready to use. You can see example here. Where would you expect the examples/documentation?

I think it's fair to add migration guide to README, let's do that 👍🏽

Thanks for feedback! Api should allow similar (and more) functionalities.

@wrapupc
Copy link
Author

wrapupc commented Apr 13, 2023 via email

@abhimanyuchugh
Copy link

@bwplotka Do you know if the migration guide was added in the end? I can't find it anywhere.

Since the go-grpc-prometheus package used global vars/package imports to do metric registration, it means we can't support both old and new package to stagger the migration and need to do a complete cutover. Is it safe to assume the new package is a straight replacement and there are no breaking changes, otherwise it makes it difficult to test the migration to new package?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants