We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
message TimestampRange { google.protobuf.Timestamp after = 1; google.protobuf.Timestamp before = 2; } message GetFoosRequest { TimestampRange created_at = 1; string other_filter = 2; } service Foo { rpc GetFoos (GetFoosRequest) returns (GetFoosResponse) { option (google.api.http) = { get: "/v1/foos" }; } }
json_names_for_fields=true
"parameters": [ { "name": "created_at.after", "in": "query", "required": false, "type": "string", "format": "date-time" }, { "name": "created_at.before", "in": "query", "required": false, "type": "string", "format": "date-time" }, { "name": "otherFilter", "in": "query", "required": false, "type": "string" }, ]
The GET parameter should be createdAt.after.
createdAt.after
Prefix assembly uses field.GetName() without checking GetUseJSONNamesForFields here:
field.GetName()
GetUseJSONNamesForFields
grpc-gateway/protoc-gen-swagger/genswagger/template.go
Line 204 in e16fcd4
The text was updated successfully, but these errors were encountered:
Fix grpc-ecosystem#1125: JSON-prefix nested-field params.
cde1561
@johanbrandhorst I went ahead and put up #1126 for this (with a test case).
Sorry, something went wrong.
f0d0de4
Fix grpc-ecosystem#1125: JSON-prefix nested-field params. (grpc-ecosy…
0ef14fe
…stem#1126) * Fix grpc-ecosystem#1125: JSON-prefix nested-field params. * Add test case.
c4ef054
No branches or pull requests
Steps you follow to reproduce the error:
json_names_for_fields=true
What did you expect to happen instead:
The GET parameter should be
createdAt.after
.What's your theory on why it isn't working:
Prefix assembly uses
field.GetName()
without checkingGetUseJSONNamesForFields
here:grpc-gateway/protoc-gen-swagger/genswagger/template.go
Line 204 in e16fcd4
The text was updated successfully, but these errors were encountered: