-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option -module does not work anymore for protoc-gen-grpc-gateway v2 #1753
Comments
olivierlemasle
added a commit
to olivierlemasle/grpc-gateway
that referenced
this issue
Oct 14, 2020
When option module=... is used, protoc-gen-grpc-gateway removes the module prefix a first time, then uses protogen, which tries to remove the prefix a second time. Fixes grpc-ecosystem#1753
Created PR #1754 to fix it |
olivierlemasle
added a commit
to olivierlemasle/grpc-gateway
that referenced
this issue
Oct 14, 2020
When option module=... is used, protoc-gen-grpc-gateway removes the module prefix a first time, then uses protogen, which tries to remove the prefix a second time. Fixes grpc-ecosystem#1753
johanbrandhorst
pushed a commit
that referenced
this issue
Oct 15, 2020
When option module=... is used, protoc-gen-grpc-gateway removes the module prefix a first time, then uses protogen, which tries to remove the prefix a second time. Fixes #1753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
The option module fails for protoc-gen-grpc-gateway v2.
Actually, the issue is that the module prefix is removed a first time by protoc-gen-grpc-gateway, then protogen attempts to remove the prefix a second time. It then fails with an error "generated file does not match prefix".
To Reproduce
Create a service file
service.proto
:Generate protobuf definitions and go-grpc with option
module=
:It generates definitions in the right directory:
Then, use protoc-gen-grpc-gateway with the same
module=
option:It fails with:
Expected behavior
I'd expect the last command to generate
your/service/v1/service_grpc.pb.go
.Actual Behavior
See above
Your Environment
Fedora 32
The text was updated successfully, but these errors were encountered: