-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tags in service annotations #2817
Comments
I found this which may indicate that its still a TODO? https://github.com/grpc-ecosystem/grpc-gateway/blob/master/protoc-gen-openapiv2/options/openapiv2.proto#L96 |
I think it is just the tags, as you say, not the entire service option. I have updated the title. Would you be interesting in helping implement this? |
See also: #2751 |
Hi @johanbrandhorst, can I try to work on this issue? |
Hi, yes, please feel free to start working on this, thank you! |
I would like to contribute to fix this issue. Thank you!! |
We have an open PR already: #2858. No need to start work on this. |
It seems that the
service
option in OpenAPI configuration file is not working, or at least I am unable to get it to work.The
protoc
compiles and successfully generates the swagger but thetags
is not getting updated with the description set by theservice
tag. Here is OpenAPIServiceOptionI also checked unannotated_echo_service.swagger.yaml and could not find the corresponding service description in unannotated_echo_service.swagger.json (which im assuming is the generated swagger output of
unannotated_echo_service.swagger.yaml
)However, in the a_bit_of_everything.proto where the annotations are in the proto file, it seems the tags for the service are properly generated in a_bit_of_everything.swagger.json
The text was updated successfully, but these errors were encountered: