-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace openapiv2 path template parser with httprule parser #2824
Labels
Comments
johanbrandhorst
added a commit
that referenced
this issue
Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with our grpc-gateway handler parser. In the future, ideally we'd unify these two parsers (see #2824).
johanbrandhorst
added a commit
that referenced
this issue
Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with our grpc-gateway handler parser. In the future, ideally we'd unify these two parsers (see #2824).
johanbrandhorst
added a commit
that referenced
this issue
Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with our grpc-gateway handler parser. In the future, ideally we'd unify these two parsers (see #2824).
johanbrandhorst
added a commit
that referenced
this issue
Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with our grpc-gateway handler parser. In the future, ideally we'd unify these two parsers (see #2824).
johanbrandhorst
added a commit
that referenced
this issue
Aug 3, 2022
* Fix openapiv2 path parameter parsing when colon in verb This makes the openapiv2 path parameter parser consistent with our grpc-gateway handler parser. In the future, ideally we'd unify these two parsers (see #2824). * Allow colons inside variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have at least two parsers for the http.proto template language;
protoc-gen-grpc-gateway
to generate the handler pathsWe should unify these two places, and we should be using the one in
httprule
. I did a little bit of investigating and I think it should be possible without too much work, and then we'd have consistency between the two generators.The text was updated successfully, but these errors were encountered: