Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace openapiv2 path template parser with httprule parser #2824

Open
johanbrandhorst opened this issue Jul 31, 2022 · 0 comments
Open

Replace openapiv2 path template parser with httprule parser #2824

johanbrandhorst opened this issue Jul 31, 2022 · 0 comments

Comments

@johanbrandhorst
Copy link
Collaborator

We have at least two parsers for the http.proto template language;

  • In the httprule package, which is used by protoc-gen-grpc-gateway to generate the handler paths
  • In the genopenapi package to generate the OpenAPI paths.

We should unify these two places, and we should be using the one in httprule. I did a little bit of investigating and I think it should be possible without too much work, and then we'd have consistency between the two generators.

johanbrandhorst added a commit that referenced this issue Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with
our grpc-gateway handler parser. In the future, ideally we'd
unify these two parsers (see #2824).
johanbrandhorst added a commit that referenced this issue Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with
our grpc-gateway handler parser. In the future, ideally we'd
unify these two parsers (see #2824).
johanbrandhorst added a commit that referenced this issue Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with
our grpc-gateway handler parser. In the future, ideally we'd
unify these two parsers (see #2824).
johanbrandhorst added a commit that referenced this issue Jul 31, 2022
This makes the openapiv2 path parameter parser consistent with
our grpc-gateway handler parser. In the future, ideally we'd
unify these two parsers (see #2824).
johanbrandhorst added a commit that referenced this issue Aug 3, 2022
* Fix openapiv2 path parameter parsing when colon in verb

This makes the openapiv2 path parameter parser consistent with
our grpc-gateway handler parser. In the future, ideally we'd
unify these two parsers (see #2824).

* Allow colons inside variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant