Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
First off, thanks for making this! It seems very helpful and needed.
I'm still learning about grpc and protobufs, so I may be mistaken, but I think there were a few issues in the README that I had to figure out in order to get it to work. Please take a look.
I think they are valid fixes.
The first change:
I needed to add that semicolon, otherwise an error was being generated when running
protoc
command:Next change:
I needed to make that change, otherwise
protoc
command generated this error:This change makes sense, as
options.proto
file is indeed located at$GOPATH/src/github.com/gengo/grpc-gateway/options/options.proto
and not$GOPATH/github.com/gengo/grpc-gateway/options/options.proto
.The rest are just typo fixes.