Fix hand-crafted protobuf message #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errorBody is an improperly hand-crafted protobuf Message. In particular, field number 1 is used twice, causing this to message to crash in the v2 re-implementation of Go protobufs. This PR modifies the field numbers to be unique. Since Error is a special field not in status.proto, we choose a large field number to avoid conflicting with any new field that may be added to the real Status message. We also fix the field numbers to truly match up with Status.
|
\cc @johanbrandhorst |
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
=========================================
Coverage ? 53.41%
=========================================
Files ? 40
Lines ? 4038
Branches ? 0
=========================================
Hits ? 2157
Misses ? 1679
Partials ? 202
Continue to review full report at Codecov.
|
|
@dsnet, hope that wasn't too hard to track down. Sorry about that! |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
errorBody is an improperly hand-crafted protobuf Message. In particular, field number 1 is used twice, causing this to message to crash in the v2 re-implementation of Go protobufs. This PR modifies the field numbers to be unique. Since Error is a special field not in status.proto, we choose a large field number to avoid conflicting with any new field that may be added to the real Status message. We also fix the field numbers to truly match up with Status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorBody is an improperly hand-crafted protobuf Message.
In particular, field number 1 is used twice, causing this to
message to crash in the v2 re-implementation of Go protobufs.
This PR modifies the field numbers to be unique.
Since Error is a special field not in status.proto,
we choose a large field number to avoid conflicting with
any new field that may be added to the real Status message.
We also fix the field numbers to truly match up with Status.