Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small performance fix #1027

Merged

Conversation

dshemin
Copy link

@dshemin dshemin commented Sep 3, 2019

Move static regexp to a global variable in order to avoid multiple
regexp pattern compilations.

Before fix:

BenchmarkPopulateQueryParameters-8   	    5000	    303218 ns/op	  217132 B/op	    2323 allocs/op
BenchmarkTemplateToSwaggerPath/with_JSON_names-8         	  200000	      9134 ns/op	    5848 B/op	     130 allocs/op
BenchmarkTemplateToSwaggerPath/without_JSON_names-8      	  200000	      9467 ns/op	    5486 B/op	     134 allocs/op

After fix:

BenchmarkPopulateQueryParameters-8   	   20000	     80937 ns/op	   10088 B/op	     345 allocs/op
BenchmarkTemplateToSwaggerPath/with_JSON_names-8         	  200000	      5846 ns/op	    2860 B/op	      99 allocs/op
BenchmarkTemplateToSwaggerPath/without_JSON_names-8      	  200000	      6039 ns/op	    2486 B/op	     103 allocs/op

Move static regexp to a global variable in order to avoid multiple
regexp pattern compilations.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thinking, thanks for the contribution! Could you please sign the CLA?

@dshemin
Copy link
Author

dshemin commented Sep 4, 2019

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@dshemin
Copy link
Author

dshemin commented Sep 4, 2019

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 4, 2019
@johanbrandhorst johanbrandhorst merged commit 7f57073 into grpc-ecosystem:master Sep 4, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants