Updates grpc proto deps #1053
Merged
Updates grpc proto deps #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgersh
force-pushed
the
updates-grpc-proto-deps
branch
from
1102112 to
8e05963
Compare
|
@johanbrandhorst - can we get |
johanbrandhorst
approved these changes
Oct 2, 2019
|
Please rebase on master. |
added 4 commits
October 2, 2019 07:34
- sed was removed as it was slow and not the canonical way to implement a replace of a go package now that modules have been introduced - go test commands were correct as the elipsis was not testing the right thing - test.Short was added to the rest of the integration tests just in case users wanted to use the -short directive and skip those (matching the style throughout the rest of the integrations
- gazelle has a slightly different command you need to use based on us using the go.mod to manage our dependencies
zachgersh
force-pushed
the
updates-grpc-proto-deps
branch
from
3bc5328 to
d4d0db2
Compare
- stops all the go.mod craziness since they've switched between gopkg.in and github as their module name. - need to upgrade this to v2 in reality but that will depend on what swagger codegen is doing
johanbrandhorst
approved these changes
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 41 41
Lines 4147 4147
=======================================
Hits 2233 2233
Misses 1670 1670
Partials 244 244Continue to review full report at Codecov.
|
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* makefile now actually tests correctly - sed was removed as it was slow and not the canonical way to implement a replace of a go package now that modules have been introduced - go test commands were correct as the elipsis was not testing the right thing - test.Short was added to the rest of the integration tests just in case users wanted to use the -short directive and skip those (matching the style throughout the rest of the integrations * fixing the bazel bits * re-run generation with newer circle dockerfile * updates contributing to note usage of go.mod - gazelle has a slightly different command you need to use based on us using the go.mod to manage our dependencies * move backwards to resty 1.8.0 - stops all the go.mod craziness since they've switched between gopkg.in and github as their module name. - need to upgrade this to v2 in reality but that will depend on what swagger codegen is doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to just bump the two most important dependencies but then had to make some modifications to the makefile so that everything would run correctly.
This has also bumped gazelle up one minor to take advantage of the fact it supports
go.modreplace directives.Tested with: