-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger 2.4.8 #1058
Swagger 2.4.8 #1058
Conversation
- had to update the makefile as the generated file names have all moved around a little bit - moved bazel forward to use go 1.13.1 as well - test that was using a deep reflect to do equality has changed to be per struct field equality (deep reflect no longer works with the enum types).
This is the best news I've heard in weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, lets get it in ASAP.
Would need one more dockerfile rebuild here. |
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 41 41
Lines 4147 4147
=======================================
Hits 2233 2233
Misses 1670 1670
Partials 244 244 Continue to review full report at Codecov.
|
Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
Lets merge this, I'll do a rebuild of the image on master. |
* generate files with swagger-codegen 2.4.8 * swagger-codegen 2.4.8 is now the base requirement - had to update the makefile as the generated file names have all moved around a little bit - moved bazel forward to use go 1.13.1 as well - test that was using a deep reflect to do equality has changed to be per struct field equality (deep reflect no longer works with the enum types). * remove need for env var * adds -e plus refactors tools to top * Update .circleci/Dockerfile Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
file names have all moved around a little bit
has changed to be per struct field equality (deep
reflect no longer works with the enum types).
as they use the standard lib for http requests.
Biggest bit - you cannot generate both an
rpc
and a regularservice
in the same directory at this version. Why? In our example they both use an optional type which used to be simple a string but nowswagger-codegen
creates a struct. The struct has the same name for both versions and you get a type redeclaration (sad).Went and had a look at swagger-codegens repo for any open issues around this and saw 0. I don't think users actually do this so it seemed alright to remove it from our test generation.