-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding build-scoping for builds on earlier go versions (<1.12) #1062
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hi @marcusljx, this looks great. I think you need to run the generator for the bazel files. See |
Or if you want to do it manually, this file is a list of the |
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 53.84% 53.84%
=======================================
Files 41 42 +1
Lines 4147 4147
=======================================
Hits 2233 2233
Misses 1670 1670
Partials 244 244
Continue to review full report at Codecov.
|
Thanks @johanbrandhorst and @achew22! I ended up going with the manual route, as I kept getting a |
@marcusljx, thanks so much for fixing up the BUILD files! This looks good to me. I'm going to let @johanbrandhorst take one more look at it and merge it but looks good on my front. |
Thanks for your contribution! |
* adding build-scoping for builds on earlier go versions (<1.12) * updating `BUILD.bazel`
Fixes #1061
This PR moves the helper function using
strings.ReplaceAll
to a new file which has build tags forgo.1.12
, limiting it togo1.12+
builds. Also added a file forgo
versions lesser than1.12
, usingstrings.Replace
in place ofstrings.ReplaceAll
.