-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotations: Sort import order. #1072
Conversation
FYI - the protoc -I /usr/local/bin//../include -I. -Ithird_party/googleapis --plugin=bin/protoc-gen-swagger --swagger_out=logtostderr=true,allow_repeated_fields_in_body=true,use_go_templates=true,Mgoogle/protobuf/field_mask.proto=google.golang.org/genproto/protobuf/field_mask,Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mexamples/proto/sub/message.proto=github.com/grpc-ecosystem/grpc-gateway/examples/proto/sub,grpc_api_configuration=examples/proto/examplepb/unannotated_echo_service.yaml:. examples/proto/examplepb/echo_service.proto examples/proto/examplepb/a_bit_of_everything.proto examples/proto/examplepb/wrappers.proto examples/proto/examplepb/stream.proto examples/proto/examplepb/unannotated_echo_service.proto examples/proto/examplepb/use_go_template.proto examples/proto/examplepb/response_body_service.proto
generate -i examples/proto/examplepb/echo_service.swagger.json \
-l go -o examples/clients/echo --additional-properties packageName=echo
make: generate: Command not found
make: *** [Makefile:169: examples/clients/echo/client.go] Error 127 |
Codecov Report
@@ Coverage Diff @@
## master #1072 +/- ##
=======================================
Coverage 54.01% 54.01%
=======================================
Files 42 42
Lines 4199 4199
=======================================
Hits 2268 2268
Misses 1683 1683
Partials 248 248 Continue to review full report at Codecov.
|
@someone1, Thanks for sending in the patch! Every little bit helps us out. WRT the issue you're having on windows building @johanbrandhorst's repo, could I have you open an issue there so it doesn't get lost? Thanks again! |
The Docker image seems to be generated from this repo? Should I open an issue here? |
@someone1 please raise a separate issue about the docker image. You did indeed find the source. I am out of the country at the moment but will have a look when I have time. |
It inadvertently got caught in my proto file linter script which checks against Google's Proto Style Guide