[bazel] Correctly handle proto files under _virtual_imports

[Yannic]

This can happen if:

1. proto_library contains at least one of import_prefix/strip_import_prefix, or
2. (for Bazel >= 1.0) at least one of proto_library's srcs is generated.

Fixes #1094

@prestonvanloon I took the liberty to include a commit from your repro in this PR to have a target that fails without the patch and passes with it. I hope you don't mind :).

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[codecov-io]

Codecov Report

Merging #1095 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   53.89%   53.89%           
=======================================
  Files          42       42           
  Lines        4180     4180           
=======================================
  Hits         2253     2253           
  Misses       1681     1681           
  Partials      246      246

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c06998...612e0b6. Read the comment docs.

[prestonvanloon]

I’m glad I could help! Thanks

[achew22]

Sorry, I spent all day on an airplane. I'll confirm the CLA stuff in the morning and merge

[prestonvanloon]

This PR doesn't totally resolve my issue.

When I use this in my real project, I am still having virtual import issues.

eth/v1alpha1/attestation.proto: File not found.
eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/beacon_block.proto: Import "eth/v1alpha1/attestation.proto" was not found or had errors.
eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/beacon_block.proto:67:14: "ethereum.eth.v1alpha1.Attestation" seems to be defined in "eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/attestation.proto", which
is not imported by "eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/beacon_block.proto".  To use it here, please add the necessary import.
eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/beacon_block.proto:174:5: "ethereum.eth.v1alpha1.AttestationData" seems to be defined in "eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/attestation.proto", which is not imported by "eth/v1alpha1/_virtual_imports/proto/eth/v1alpha1/beacon_block.proto".  To use it here, please add the necessary import.

Link to PR: prysmaticlabs/ethereumapis#33

Any idea @Yannic ?

[Yannic]

@prestonvanloon This is weird. I see there is //tools:proto_descriptor_sets.bzl which contains the same mistake I fixed here, so just to make sure the failure you mention above is caused by protoc_gen_swagger, can you run bazel build //eth/v1alpha1:swagger in your repo and report back? If that works, I'll guide you through fixing proto_descriptor_sets.

[prestonvanloon]

Confirmed bazel build //eth/v1alpha1:swagger works! I forgot about the proto descriptor set rule.

Maybe that could be a feature for rules_bazel? I needed the descriptor set to give to envoy grpc gateway proxy.

[Yannic]

I assume you mean rules_proto. Can you open a feature request there?

If you need a single descriptor set with transitive imports, I recommend
bazel build --protocopt=--include_imports --protocopt=--include_source_info //eth/v1alpha1:proto for now. (Disclaimer: Don't put these --protocopt into your .bazelrc, these descriptor sets can get quite large which does impact build performance.)

[prestonvanloon]

Oh yes, I meant rules_proto. Sorry about that! Oh awesome, this resolves my problem for now. Thanks!

[Yannic]

@achew22 friendly ping?

[achew22]

@Yannic, thanks for pinging. Sorry about that.

@prestonvanloon could you follow the instructions from the CLA bot:

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Based on the dashboard I think that should be sufficient. Thanks so much!

[prestonvanloon]

@googlebot I consent.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[achew22]

Let's ship it. Thanks to both of you!