-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1109 Inline streamingDefinitions in generated swagger to better support codegen tools #1112
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
- Coverage 53.89% 53.87% -0.03%
==========================================
Files 42 42
Lines 4180 4165 -15
==========================================
- Hits 2253 2244 -9
+ Misses 1681 1677 -4
+ Partials 246 244 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for your contribution!
…to better support codegen tools (grpc-ecosystem#1112) * grpc-ecosystem#1109 Inline streamingDefinitions in generated swagger * Updated generated swagger streaming examples
Fixes #1109