Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1109 Inline streamingDefinitions in generated swagger to better support codegen tools #1112

Merged
merged 2 commits into from
Jan 18, 2020

Conversation

seanlaff
Copy link
Contributor

Fixes #1109

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@seanlaff
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

Merging #1112 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   53.89%   53.87%   -0.03%     
==========================================
  Files          42       42              
  Lines        4180     4165      -15     
==========================================
- Hits         2253     2244       -9     
+ Misses       1681     1677       -4     
+ Partials      246      244       -2
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/types.go 0% <ø> (ø) ⬆️
protoc-gen-swagger/genswagger/generator.go 10.31% <ø> (+0.16%) ⬆️
protoc-gen-swagger/genswagger/template.go 57.19% <100%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8db07a...dcdc109. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for your contribution!

@johanbrandhorst johanbrandhorst merged commit 0c6cfab into grpc-ecosystem:master Jan 18, 2020
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
…to better support codegen tools (grpc-ecosystem#1112)

* grpc-ecosystem#1109 Inline streamingDefinitions in generated swagger

* Updated generated swagger streaming examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming responses are put in x-stream-definitions rather than /components/schema, which tools do not support
4 participants