Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fqn_for_swagger_name to bazel defs #1528

Conversation

chriserickson
Copy link
Contributor

References to other Issues or PRs

#881

Brief description of what is fixed or changed

Support for setting the fqn_for_swagger_name flag was not exposed through the bazel rules. This follows the same pattern used for json_names_for_fields, but it begs the question to me as to whether there should be a more generic way to set these arguments, as there are a lot more flags that can be set that are not exposed.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're happy to do these on a case by case basis for now. It's clear enough what each one does.

@johanbrandhorst johanbrandhorst merged commit 1d1ff5e into grpc-ecosystem:master Jul 16, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry pick this against the v2 branch?

@chriserickson
Copy link
Contributor Author

Sure: #1529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants