Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SendHeader/SetTrailer when use grpc-gateway standalone server (v2) #1638

Merged
merged 5 commits into from
Sep 3, 2020
Merged

fix SendHeader/SetTrailer when use grpc-gateway standalone server (v2) #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d371af5
add ServerTransportStream in context for local gateway handlers
ghostiam Sep 2, 2020
f2ad470
regenerate files
ghostiam Sep 2, 2020
c9186e4
fix lint
ghostiam Sep 2, 2020
81abcfd
fix bazel test
ghostiam Sep 3, 2020
9b5eed4
fix after review
ghostiam Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion examples/internal/helloworld/helloworld.pb.gw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions examples/internal/integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ func TestEcho(t *testing.T) {
testEchoOneof1(t, 8088, apiPrefix, "application/json")
testEchoOneof2(t, 8088, apiPrefix, "application/json")
testEchoBody(t, 8088, apiPrefix)
// Use SendHeader/SetTrailer without gRPC server https://github.com/grpc-ecosystem/grpc-gateway/issues/517#issuecomment-684625645
testEchoBody(t, 8089, apiPrefix)
})
}
}
Expand Down
Loading