End default response desc with period #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something seems to be weird with the test run 🤔. |
|
Going to try closing and reopening the PR |
|
That seems to have triggered the jobs 🎉 |
|
Thanks for your contribution, could you cherry-pick this against the v2 branch please? |
rubda
added a commit
to rubda/grpc-gateway
that referenced
this pull request
Sep 14, 2020
|
Sure, #1667. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
N/A
Have you read the Contributing Guidelines?
Yes.
Brief description of what is fixed or changed
Ending the default response description with a period.
Other comments
Seeing as
A successful response.ends with a period, I thought this would be appropriate.