Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets proper context property for openapi_configuration option #1837

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Sets proper context property for openapi_configuration option #1837

merged 1 commit into from
Nov 24, 2020

Conversation

zoido
Copy link
Contributor

@zoido zoido commented Nov 23, 2020 •
edited
Loading

References to other Issues or PRs

RESOLVES #1838

Have you read the Contributing Guidelines?

Yes.

Brief description of what is fixed or changed

uses proper ctx property to pass openapi_configuration option to the _run_proto_gen_openapi

@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@zoido zoido marked this pull request as ready for review November 23, 2020 08:47
johanbrandhorst
johanbrandhorst approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanbrandhorst johanbrandhorst merged commit ff93fab into grpc-ecosystem:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openapi_configuration option in protoc_gen_openapiv2 Bazel rule fails.
2 participants
@zoido @johanbrandhorst