Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken example #1843

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Fix broken example #1843

merged 2 commits into from
Nov 28, 2020

Conversation

isbang
Copy link
Contributor

@isbang isbang commented Nov 27, 2020

References to other Issues or PRs

Fixes #1842

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Import package errdetails so that protojson can translate errdetails.DebugInfo as google.protobuf.Any

Other comments

@isbang
Fix broken example
c4d9c25 
add missing errdetails import so that protojson can
translate errdetails as google.protobuf.Any

fix grpc-ecosystem#1842
@google-cla google-cla bot added the cla: yes label Nov 27, 2020
johanbrandhorst
johanbrandhorst approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Have you confirmed that this fixes the error?

@johanbrandhorst
Copy link
Collaborator

See https://github.com/grpc-ecosystem/grpc-gateway/blob/master/CONTRIBUTING.md#using-docker for regenerating the bazel files

@isbang
Copy link
Contributor Author

isbang commented Nov 27, 2020 •
edited
Loading

Nice work! Have you confirmed that this fixes the error?

Yes!
image

@johanbrandhorst
Copy link
Collaborator

Yes, that looks right to me! It's a peculiarity in how the google.protobuf.Any type marshals to JSON.

@isbang
Copy link
Contributor Author

isbang commented Nov 27, 2020

Thanks for guide me @johanbrandhorst 😆

@codecov-io
Copy link

Codecov Report

Merging #1843 (c60f485) into master (865774a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1843   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files          34       34           
  Lines        3754     3754           
=======================================
  Hits         2180     2180           
  Misses       1301     1301           
  Partials      273      273

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865774a...c60f485. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 87286d1 into grpc-ecosystem:master Nov 28, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected response on /v2/example/errorwithdetails
3 participants
@isbang @johanbrandhorst @codecov-io