Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ## Docs section to highlight the docs URL #1884

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

VinGarcia
Copy link
Contributor

References to other Issues or PRs

As suggested on issue #1882
I am creating this PR to make the link to the documentation site
more visible on the README file.

Brief description of what is fixed or changed

Add a ### Docs section to the README file.

Other comments

It was also suggested that I created a ### Customizing your gateway section to the README, but I don't feel qualified yet for writing this section, so I just created this first one.

It is also worth noting that the docs already have a Customizing your gateway section which will be very helpful if more people find this page.

@google-cla
Copy link

google-cla bot commented Dec 29, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst
Copy link
Collaborator

Could you please sign the CLA and reply to the bot?

@VinGarcia
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 30, 2020
@VinGarcia
Copy link
Contributor Author

Done @johanbrandhorst, is there anything else?

@johanbrandhorst johanbrandhorst merged commit c02dbaf into grpc-ecosystem:master Dec 30, 2020
@johanbrandhorst
Copy link
Collaborator

Nah, that was it! The fuzzit job has started failing occasionally, unfortunately. I reran it once, but it was still unhappy so we'll just leave it. Thanks for your contribution 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants