-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix malformed Schema Reference during field_behavior generation #1944
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Quick scan looks like this test relies on stable order from ranging over a map. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR @gganley! I left a note about adding a comment to explain the behaviour, and I'm generally confused as to why we need the new proto dependencies.
Hi, please rebase on |
bump third_part proto files to same revision
🤦 Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst apologies if it's not the proper etiquette to re-request reviews rather than resolving the conversations myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix 😄.
References to other Issues or PRs
Fixes #1937
Have you read the Contributing Guidelines?
To the best of my ability.
Brief description of what is fixed or changed
The
required
field was being added to a schema reference, this no longer does so.Other comments
Added two googleapi proto files to help conform to google AIP examples.