Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error on invalid nested query parameters. #329

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Return an error on invalid nested query parameters. #329

merged 2 commits into from
Mar 15, 2017

Conversation

fische
Copy link
Contributor

@fische fische commented Mar 15, 2017

  • Fix Panic with query parameters #324.
  • Return an error instead of panicking when trying to retrieve a subfield of a non-object field.
  • Add some tests to prevent regression.

@fische
Copy link
Contributor Author

fische commented Mar 15, 2017 •
edited
Loading

Ping for cla/google

@tmc
Copy link
Collaborator

tmc commented Mar 15, 2017

@fische thank you for your contribution!

@tmc tmc merged commit 7980281 into grpc-ecosystem:master Mar 15, 2017
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
Closed
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@fische @tmc
Return an error on invalid nested query parameters. (grpc-ecosystem#329)
5336e1e 
* Add some tests with invalid nested query paramters.

* Return an error when an invalid nested field is passed in query parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fische @tmc