fix: use req.Body instead of IOReaderFactory when possible

[leungster]

References to other Issues or PRs

Fixes #3714

Have you read the Contributing Guidelines?

yes

Brief description of what is fixed or changed

Changes request RPCs to use req.Body instead of reading into an in memory byte slice via IOReaderFactory. The IOReaderFactory is still available for the PATCH field_mask feature.

Summary by CodeRabbit

• New Features
  • Enhanced request body processing logic to handle field masks more efficiently.
• Tests
  • Updated test cases to reflect changes in request body processing.

[coderabbitai]

Walkthrough

The changes primarily focus on improving the efficiency of the utilities.IOReaderFactory in a Go project. The modifications introduce conditional logic for field mask decoding and refactor the code to use a newReader function for decoding in certain cases. The changes also include updates to the applyTemplate function in two test cases.

Changes

File	Change Summary
.../gengateway/template.go	Introduced conditional logic for field mask decoding based on the HTTP method and field mask presence. Refactored the code to use a newReader function for decoding in certain cases.
.../gengateway/template_test.go	Updated the applyTemplate function in two test cases. Replaced marshaler.NewDecoder(newReader()).Decode(&protoReq.GetNested().Bool) with marshaler.NewDecoder(req.Body).Decode(&protoReq.GetNested().Bool). Added a new check for marshaler.NewDecoder(newReader()).Decode(&protoReq.Abe) in the TestAllowPatchFeature function.

Assessment against linked issues (Beta)

Objective	Addressed	Explanation
Reduce memory utilization by avoiding io.ReadAll in utilities.IOReaderFactory (#3714)	✅	The changes replace the use of io.ReadAll with a more efficient newReader function, which should reduce memory utilization.
Ensure that the service does not run out of memory with large inputs (#3714)	❓	It's unclear without performance testing whether the changes sufficiently reduce memory utilization to prevent the service from running out of memory with large inputs.

Poem

🍂 As autumn leaves gently fall, 🍁

CodeRabbit hops, answering the call. 🐇💻

With each change and refactor, 🔄

Memory usage we aim to factor. 📉

On this day, in history's page, 📜

Marie Curie was born, a scientific sage. 🧪👩‍🔬

So let's celebrate with code so neat, 🎉

Making our Go project more complete! 🥳🎈

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai help to get help.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 552a019 and 9b4ce70.

Files ignored due to filter (12)

• examples/internal/proto/examplepb/a_bit_of_everything.pb.gw.go
• examples/internal/proto/examplepb/echo_service.pb.gw.go
• examples/internal/proto/examplepb/flow_combination.pb.gw.go
• examples/internal/proto/examplepb/generate_unbound_methods.pb.gw.go
• examples/internal/proto/examplepb/ignore_comment.pb.gw.go
• examples/internal/proto/examplepb/openapi_merge_a.pb.gw.go
• examples/internal/proto/examplepb/openapi_merge_b.pb.gw.go
• examples/internal/proto/examplepb/remove_internal_comment.pb.gw.go
• examples/internal/proto/examplepb/unannotated_echo_service.pb.gw.go
• examples/internal/proto/examplepb/use_go_template.pb.gw.go
• examples/internal/proto/examplepb/wrappers.pb.gw.go
• examples/internal/proto/standalone/unannotated_echo_service.pb.gw.go

Files selected for processing (2)

• protoc-gen-grpc-gateway/internal/gengateway/template.go (2 hunks)
• protoc-gen-grpc-gateway/internal/gengateway/template_test.go (2 hunks)

Additional comments: 3

protoc-gen-grpc-gateway/internal/gengateway/template_test.go (2)

• 242-242: The test case has been updated to check for the new decoding logic using req.Body. Ensure that this change aligns with the updated logic in the main code.

• 662-664: A new test case has been added to check for the decoding logic using newReader(). This is specifically for the allowPatchFeature scenario. Ensure that this test case is necessary and that it correctly tests the intended functionality.

protoc-gen-grpc-gateway/internal/gengateway/template.go (1)

• 513-532: This hunk is a duplicate of the previous hunk. The same comments apply.

[johanbrandhorst]

Amazing, thank you!

[johanbrandhorst]

Thanks for your contribution!