Fix name tags in methods #3843
Merged
Fix name tags in methods #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generating openapi docs
[Bug grpc-ecosystem#3829] consider openapiv2_tag.name attribute when generating ope…
WalkthroughThe recent updates focus on ensuring that custom names specified via the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- examples/internal/clients/abe/api/swagger.yaml
- examples/internal/proto/examplepb/a_bit_of_everything.pb.go
- examples/internal/proto/examplepb/a_bit_of_everything.swagger.json
Files selected for processing (3)
- examples/internal/clients/abe/client.go (2 hunks)
- examples/internal/proto/examplepb/a_bit_of_everything.proto (1 hunks)
- protoc-gen-openapiv2/internal/genopenapi/template.go (2 hunks)
Additional comments: 3
examples/internal/clients/abe/client.go (1)
- 74-74: The assignment of
ABitOfEverythingApiwithinNewAPIClienthas been updated to match the new type name. Confirm that the initialization of this field is consistent with the new type across all instances whereNewAPIClientis called.Verification successful
The script output confirms that within the
NewAPIClientfunction inabe/client.go, theABitOfEverythingApiis initialized as(*ABitOfEverythingApiService)(&c.common), which is consistent with the type change described in the PR and the AI-generated summary. This indicates that the initialization ofABitOfEverythingApiis correct with respect to the new type name.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for the NewAPIClient function to ensure the field is correctly initialized. rg --type go 'NewAPIClient'Length of output: 1730
Script:
#!/bin/bash # Extract the implementation of NewAPIClient from abe/client.go to verify the initialization of ABitOfEverythingApi. rg --type go -A 10 'func NewAPIClient\(cfg \*Configuration\) \*APIClient {' examples/internal/clients/abe/client.goLength of output: 289
Script:
#!/bin/bash # Correct the regex pattern and extract the implementation of NewAPIClient from abe/client.go. rg --type go -A 10 'func NewAPIClient\(cfg \*Configuration\) \*APIClient' examples/internal/clients/abe/client.goLength of output: 373
examples/internal/proto/examplepb/a_bit_of_everything.proto (1)
- 498-498: The
namefield has been added to theopenapiv2_tagoption with the value "ABitOfEverything". This change is intended to ensure that thenameattribute is used when generating documentation. Confirm that the newnamefield is reflected in the generatedswagger.jsonand other relevant documentation artifacts.Verification successful
The verification scripts have provided the following information:
- The
swagger.jsonfile contains the"name": "ABitOfEverything"entry, which confirms that thenamefield has been updated in the Swagger documentation as intended by the pull request.- References to
ABitOfEverythingServiceare still present in the markdown documentation files.Given this information, the change to the
openapiv2_tagoption with the value "ABitOfEverything" has been successfully reflected in theswagger.json. However, the presence ofABitOfEverythingServicein the markdown files suggests that there may be parts of the documentation that have not been updated to reflect the newnamefield. This could be intentional, as the service name itself has not changed, only the name used in the Swagger documentation.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the swagger.json file has been updated. rg --type json '"name": "ABitOfEverything"' ./path/to/swagger.json # Check for references to the old service name in documentation. rg 'ABitOfEverythingService' ./path/to/documentationLength of output: 248
Script:
#!/bin/bash # Find the swagger.json file in the repository and check if the name "ABitOfEverything" is present. fd swagger.json --exec rg '"name": "ABitOfEverything"' # Find any documentation files in the repository and check for references to ABitOfEverythingService. fd '\.md$' --exec rg 'ABitOfEverythingService'Length of output: 171
protoc-gen-openapiv2/internal/genopenapi/template.go (1)
- 1491-1493: The logic to set the tag name based on
opts.GetName()is correct and aligns with the PR's objective to use thenameattribute within theopenapiv2tag for documentation generation. This change ensures that the specified tag name is used if provided.
Comment on lines
1485
to
1489
| opts, err := getServiceOpenAPIOption(reg, svc) | ||
| if err != nil { | ||
| grpclog.Error(err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
The error handling added to getServiceOpenAPIOption is a good practice to catch potential issues during the retrieval of service options. However, it's important to ensure that the error is handled appropriately and not just logged. Consider if there should be a return or other error handling mechanism following the logging.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 5
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- examples/internal/clients/abe/api/swagger.yaml
- examples/internal/proto/examplepb/a_bit_of_everything.swagger.json
Files selected for processing (5)
- examples/internal/clients/abe/api_a_bit_of_everything.go (1 hunks)
- examples/internal/clients/abe/api_a_bit_of_everything_service.go (7 hunks)
- examples/internal/clients/abe/client.go (2 hunks)
- protoc-gen-openapiv2/internal/genopenapi/template.go (3 hunks)
- protoc-gen-openapiv2/internal/genopenapi/template_test.go (2 hunks)
Files not summarized due to errors (1)
- examples/internal/clients/abe/api_a_bit_of_everything_service.go: Error: Message exceeds token limit
Files skipped from review as they are similar to previous changes (2)
- examples/internal/clients/abe/client.go
- protoc-gen-openapiv2/internal/genopenapi/template.go
Additional comments: 9
examples/internal/clients/abe/api_a_bit_of_everything.go (3)
28-28: The type
ABitOfEverythingApiServiceis an alias forservice. Ensure that theservicetype is correctly defined elsewhere in the codebase and that this alias is necessary and used consistently.572-719: The method
ABitOfEverythingServiceOverwriteRequestContentTypesets a fixed content type for the request. Verify that this content type is indeed required and that it does not need to be dynamically determined based on the request body.728-873: The method
ABitOfEverythingServiceOverwriteResponseContentTypesets theAcceptheader toapplication/text, which is non-standard. Confirm that the server supports this content type and that it is intentional to use it instead of the more commontext/plain.examples/internal/clients/abe/api_a_bit_of_everything_service.go (4)
4427-4427: Ensure that
newErr.erroris properly declared and handled elsewhere in the code, as it's not visible in the current hunk. IfnewErris not a known type with anerrorfield, this could be a bug.4505-4505: The function signature for
ABitOfEverythingServiceLookupis clear and concise. Ensure that theuuidparameter is validated elsewhere in the code to prevent potential security issues.4532-4532: The Accept header is being set correctly. Ensure that the content types listed are supported by the server and client.
4583-4583: Similar to the previous comment on Hunk 4, verify that
newErr.erroris properly declared and handled elsewhere in the code.protoc-gen-openapiv2/internal/genopenapi/template_test.go (2)
6347-6347: The
Descriptionfor "ExampleService" has been changed to an empty string. Ensure this is intentional and consistent with the desired documentation output.6358-6360: The addition of the "service tag" with the description "ExampleService!" appears to align with the PR's objective to use the
nameattribute within theopenapiv2tag. Confirm that this new tag is used correctly in the context of the test and reflects the intended behavior in the documentation generation.
Comment on lines
+37
to
+183
| r, err := a.client.prepareRequest(ctx, localVarPath, localVarHttpMethod, localVarPostBody, localVarHeaderParams, localVarQueryParams, localVarFormParams, localVarFileName, localVarFileBytes) | ||
| if err != nil { | ||
| return localVarReturnValue, nil, err | ||
| } | ||
|
|
||
| localVarHttpResponse, err := a.client.callAPI(r) | ||
| if err != nil || localVarHttpResponse == nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
|
|
||
| localVarBody, err := ioutil.ReadAll(localVarHttpResponse.Body) | ||
| localVarHttpResponse.Body.Close() | ||
| if err != nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode < 300 { | ||
| // If we succeed, return the data, otherwise pass on to decode error. | ||
| err = a.client.decode(&localVarReturnValue, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err == nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode >= 300 { | ||
| newErr := GenericSwaggerError{ | ||
| body: localVarBody, | ||
| error: localVarHttpResponse.Status, | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 200 { | ||
| var v interface{} | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 403 { | ||
| var v interface{} | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 404 { | ||
| var v string | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 418 { | ||
| var v ExamplepbNumericEnum | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 500 { | ||
| var v ExamplepbErrorResponse | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 0 { | ||
| var v RpcStatus | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| return localVarReturnValue, localVarHttpResponse, nil |
There was a problem hiding this comment.
The method ABitOfEverythingServiceDelete seems to handle HTTP response codes manually. Consider using a more structured approach to handle different HTTP status codes and their corresponding business logic.
Comment on lines
+292
to
+562
| r, err := a.client.prepareRequest(ctx, localVarPath, localVarHttpMethod, localVarPostBody, localVarHeaderParams, localVarQueryParams, localVarFormParams, localVarFileName, localVarFileBytes) | ||
| if err != nil { | ||
| return localVarReturnValue, nil, err | ||
| } | ||
|
|
||
| localVarHttpResponse, err := a.client.callAPI(r) | ||
| if err != nil || localVarHttpResponse == nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
|
|
||
| localVarBody, err := ioutil.ReadAll(localVarHttpResponse.Body) | ||
| localVarHttpResponse.Body.Close() | ||
| if err != nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode < 300 { | ||
| // If we succeed, return the data, otherwise pass on to decode error. | ||
| err = a.client.decode(&localVarReturnValue, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err == nil { | ||
| return localVarReturnValue, localVarHttpResponse, err | ||
| } | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode >= 300 { | ||
| newErr := GenericSwaggerError{ | ||
| body: localVarBody, | ||
| error: localVarHttpResponse.Status, | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 200 { | ||
| var v interface{} | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 403 { | ||
| var v interface{} | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 404 { | ||
| var v string | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 418 { | ||
| var v ExamplepbNumericEnum | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 500 { | ||
| var v ExamplepbErrorResponse | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 0 { | ||
| var v RpcStatus | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| return localVarReturnValue, localVarHttpResponse, nil |
There was a problem hiding this comment.
The method ABitOfEverythingServiceGetQuery has a large number of optional parameters. Consider refactoring to reduce complexity and improve maintainability, possibly by grouping related parameters into structs or using a builder pattern.
| localVarFileBytes []byte | ||
| localVarReturnValue ExamplepbABitOfEverything | ||
| ) | ||
| func (a *ABitOfEverythingServiceApiService) ABitOfEverythingServiceGetRepeatedQuery(ctx context.Context, pathRepeatedFloatValue []float32, pathRepeatedDoubleValue []float64, pathRepeatedInt64Value []string, pathRepeatedUint64Value []string, pathRepeatedInt32Value []int32, pathRepeatedFixed64Value []string, pathRepeatedFixed32Value []int64, pathRepeatedBoolValue []bool, pathRepeatedStringValue []string, pathRepeatedBytesValue []string, pathRepeatedUint32Value []int64, pathRepeatedEnumValue []string, pathRepeatedSfixed32Value []int32, pathRepeatedSfixed64Value []string, pathRepeatedSint32Value []int32, pathRepeatedSint64Value []string) (ExamplepbABitOfEverythingRepeated, *http.Response, error) { |
There was a problem hiding this comment.
The function signature has been updated to include a large number of parameters, which could indicate a complex interface that may be difficult to maintain. Consider refactoring to pass a structured object if these parameters are related.
Comment on lines
+4296
to
+4312
| localVarPath := a.client.cfg.BasePath + "/v1/example/a_bit_of_everything_repeated/{pathRepeatedFloatValue}/{pathRepeatedDoubleValue}/{pathRepeatedInt64Value}/{pathRepeatedUint64Value}/{pathRepeatedInt32Value}/{pathRepeatedFixed64Value}/{pathRepeatedFixed32Value}/{pathRepeatedBoolValue}/{pathRepeatedStringValue}/{pathRepeatedBytesValue}/{pathRepeatedUint32Value}/{pathRepeatedEnumValue}/{pathRepeatedSfixed32Value}/{pathRepeatedSfixed64Value}/{pathRepeatedSint32Value}/{pathRepeatedSint64Value}" | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedFloatValue"+"}", fmt.Sprintf("%v", pathRepeatedFloatValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedDoubleValue"+"}", fmt.Sprintf("%v", pathRepeatedDoubleValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedInt64Value"+"}", fmt.Sprintf("%v", pathRepeatedInt64Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedUint64Value"+"}", fmt.Sprintf("%v", pathRepeatedUint64Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedInt32Value"+"}", fmt.Sprintf("%v", pathRepeatedInt32Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedFixed64Value"+"}", fmt.Sprintf("%v", pathRepeatedFixed64Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedFixed32Value"+"}", fmt.Sprintf("%v", pathRepeatedFixed32Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedBoolValue"+"}", fmt.Sprintf("%v", pathRepeatedBoolValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedStringValue"+"}", fmt.Sprintf("%v", pathRepeatedStringValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedBytesValue"+"}", fmt.Sprintf("%v", pathRepeatedBytesValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedUint32Value"+"}", fmt.Sprintf("%v", pathRepeatedUint32Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedEnumValue"+"}", fmt.Sprintf("%v", pathRepeatedEnumValue), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedSfixed32Value"+"}", fmt.Sprintf("%v", pathRepeatedSfixed32Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedSfixed64Value"+"}", fmt.Sprintf("%v", pathRepeatedSfixed64Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedSint32Value"+"}", fmt.Sprintf("%v", pathRepeatedSint32Value), -1) | ||
| localVarPath = strings.Replace(localVarPath, "{"+"pathRepeatedSint64Value"+"}", fmt.Sprintf("%v", pathRepeatedSint64Value), -1) |
There was a problem hiding this comment.
Using multiple strings.Replace calls in a row can be inefficient. Consider using a more efficient method for URL construction, such as a strings.Builder or URL templating.
Comment on lines
+4317
to
+4363
|
|
||
| if localVarHttpResponse.StatusCode >= 300 { | ||
| newErr := GenericSwaggerError{ | ||
| body: localVarBody, | ||
| error: localVarHttpResponse.Status, | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 200 { | ||
| var v ExamplepbABitOfEverything | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 403 { | ||
| var v interface{} | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 404 { | ||
| var v string | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 418 { | ||
| var v ExamplepbNumericEnum | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 500 { | ||
| var v ExamplepbErrorResponse | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| if localVarHttpResponse.StatusCode == 0 { | ||
| var v RpcStatus | ||
| err = a.client.decode(&v, localVarBody, localVarHttpResponse.Header.Get("Content-Type")); | ||
| if err != nil { | ||
| newErr.error = err.Error() | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
| newErr.model = v | ||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| } | ||
|
|
||
| return localVarReturnValue, localVarHttpResponse, newErr | ||
| if len(pathRepeatedBoolValue) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedBoolValue must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedStringValue) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedStringValue must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedBytesValue) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedBytesValue must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedUint32Value) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedUint32Value must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedEnumValue) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedEnumValue must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedSfixed32Value) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedSfixed32Value must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedSfixed64Value) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedSfixed64Value must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedSint32Value) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedSint32Value must have at least 1 elements") | ||
| } | ||
| if len(pathRepeatedSint64Value) < 1 { | ||
| return localVarReturnValue, nil, reportError("pathRepeatedSint64Value must have at least 1 elements") |
There was a problem hiding this comment.
The validation checks for the presence of at least one element in each slice parameter are repeated and verbose. Consider creating a helper function to DRY (Don't Repeat Yourself) up this code.
johanbrandhorst
approved these changes
Dec 21, 2023
|
Looks like we got some test failures, if we can get this in we can get it into the next release |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- examples/internal/clients/abe/BUILD.bazel (1 hunks)
Files skipped from review due to trivial changes (1)
- examples/internal/clients/abe/BUILD.bazel
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- protoc-gen-openapiv2/internal/genopenapi/template_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- protoc-gen-openapiv2/internal/genopenapi/template_test.go
|
@johanbrandhorst got around to doing it earlier today |
charithe
referenced
this pull request
in cerbos/cerbos
Jan 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.49.13` -> `v1.49.16` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/cerbos/cloud-api](https://togithub.com/cerbos/cloud-api) | `v0.1.13` -> `v0.1.14` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | `v2.18.1` -> `v2.19.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | `v0.12.73` -> `v0.12.74` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | golang.org/x/exp | `02704c9` -> `be819d1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | golang.org/x/sync | `v0.5.0` -> `v0.6.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto) | `995d672` -> `50ed04b` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.49.16`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14916-2024-01-05) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.15...v1.49.16) \=== ##### Service Client Updates - `service/connect`: Updates service API - `service/kms`: Updates service documentation - Documentation updates for AWS Key Management Service (KMS). - `service/redshift-serverless`: Updates service documentation ##### SDK Bugs - The logging behavior in `aws/ec2metadata/token_provider.go` was updated: warnings about falling back to IMDSv1 are now logged only when LogLevel is set to `LogDebugWithDeprecated`. - This change prevents unnecessary warnings when LogLevel is set to suppress messages. ### [`v1.49.15`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14915-2024-01-04) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.14...v1.49.15) \=== ##### Service Client Updates - `service/config`: Updates service API and documentation - `service/docdb`: Updates service API and documentation - Adding PerformanceInsightsEnabled and PerformanceInsightsKMSKeyId fields to DescribeDBInstances Response. - `service/ecs`: Updates service API and documentation - This release adds support for managed instance draining which facilitates graceful termination of Amazon ECS instances. - `service/es`: Updates service API and documentation - This release adds support for new or existing Amazon OpenSearch domains to enable TLS 1.3 or TLS 1.2 with perfect forward secrecy cipher suites for domain endpoints. - `service/lightsail`: Updates service API and documentation - This release adds support to set up an HTTPS endpoint on an instance. - `service/opensearch`: Updates service API and documentation - `service/sagemaker`: Updates service API and documentation - Adding support for provisioned throughput mode for SageMaker Feature Groups - `service/servicecatalog`: Updates service API and documentation - Added Idempotency token support to Service Catalog AssociateServiceActionWithProvisioningArtifact, DisassociateServiceActionFromProvisioningArtifact, DeleteServiceAction API ### [`v1.49.14`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14914-2024-01-03) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.13...v1.49.14) \=== ##### Service Client Updates - `service/connect`: Updates service API and documentation - `service/mediaconvert`: Updates service API and documentation - This release includes video engine updates including HEVC improvements, support for ingesting VP9 encoded video in MP4 containers, and support for user-specified 3D LUTs. </details> <details> <summary>cerbos/cloud-api (github.com/cerbos/cloud-api)</summary> ### [`v0.1.14`](https://togithub.com/cerbos/cloud-api/compare/v0.1.13...v0.1.14) [Compare Source](https://togithub.com/cerbos/cloud-api/compare/v0.1.13...v0.1.14) </details> <details> <summary>grpc-ecosystem/grpc-gateway (github.com/grpc-ecosystem/grpc-gateway/v2)</summary> ### [`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0) ##### What's Changed - fix: use req.Body instead of IOReaderFactory when possible by [@​leungster](https://togithub.com/leungster) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - runtime: Add outgoing trailer matching by [@​adriansmares](https://togithub.com/adriansmares) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - Add openapiv2\_opt support for passing values to go templates via cli by [@​500poundbear](https://togithub.com/500poundbear) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - \[Bug [#​3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)] \[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when generating ope… by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - feat: partial message created as named definitions by [@​nkcr](https://togithub.com/nkcr) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) - Fix name tags in methods by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3843](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3843) - Revert [`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc) by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3856](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3856) ##### New Contributors - [@​leungster](https://togithub.com/leungster) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - [@​adriansmares](https://togithub.com/adriansmares) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - [@​500poundbear](https://togithub.com/500poundbear) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - [@​omrikiei](https://togithub.com/omrikiei) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - [@​nkcr](https://togithub.com/nkcr) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) **Full Changelog**: grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0 </details> <details> <summary>pterm/pterm (github.com/pterm/pterm)</summary> ### [`v0.12.74`](https://togithub.com/pterm/pterm/releases/tag/v0.12.74) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.73...v0.12.74) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - feat: automatically inject more `CallerOffset` in `pterm.NewSlogHandler` by [@​MarvinJWendt](https://togithub.com/MarvinJWendt) in [https://github.com/pterm/pterm/pull/609](https://togithub.com/pterm/pterm/pull/609) ##### Other Changes - examples: fixed `interactive_multiselect` examples by [@​MarvinJWendt](https://togithub.com/MarvinJWendt) in [https://github.com/pterm/pterm/pull/606](https://togithub.com/pterm/pterm/pull/606) - ci(examples): demo is now always at the top by [@​MarvinJWendt](https://togithub.com/MarvinJWendt) in [https://github.com/pterm/pterm/pull/607](https://togithub.com/pterm/pterm/pull/607) **Full Changelog**: pterm/pterm@v0.12.73...v0.12.74 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Charith Ellawala <charith@cerbos.dev> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Charith Ellawala <charith@cerbos.dev>
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jan 9, 2024
… v2.19.0 (#30353) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | `v2.18.1` -> `v2.19.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc-ecosystem/grpc-gateway (github.com/grpc-ecosystem/grpc-gateway/v2)</summary> ### [`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0) #### What's Changed - fix: use req.Body instead of IOReaderFactory when possible by [@​leungster](https://togithub.com/leungster) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - runtime: Add outgoing trailer matching by [@​adriansmares](https://togithub.com/adriansmares) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - Add openapiv2\_opt support for passing values to go templates via cli by [@​500poundbear](https://togithub.com/500poundbear) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - \[Bug [#​3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)] \[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when generating ope… by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - feat: partial message created as named definitions by [@​nkcr](https://togithub.com/nkcr) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) - Fix name tags in methods by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3843](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3843) - Revert [`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc) by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3856](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3856) #### New Contributors - [@​leungster](https://togithub.com/leungster) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - [@​adriansmares](https://togithub.com/adriansmares) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - [@​500poundbear](https://togithub.com/500poundbear) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - [@​omrikiei](https://togithub.com/omrikiei) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - [@​nkcr](https://togithub.com/nkcr) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) **Full Changelog**: grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
michaelkedar
referenced
this pull request
in google/osv.dev
Jan 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | `v2.18.1` -> `v2.19.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [go](https://go.dev/) ([source](https://togithub.com/golang/go)) | `1.21.5` -> `1.21.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | golang | patch | | [google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go) | `v1.31.0` -> `v1.32.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | | All locks refreshed | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | lockFileMaintenance | | [jekyll-feed](https://togithub.com/jekyll/jekyll-feed) | `0.15.1` -> `0.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | --- ### Release Notes <details> <summary>grpc-ecosystem/grpc-gateway (github.com/grpc-ecosystem/grpc-gateway/v2)</summary> ### [`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0) #### What's Changed - fix: use req.Body instead of IOReaderFactory when possible by [@​leungster](https://togithub.com/leungster) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - runtime: Add outgoing trailer matching by [@​adriansmares](https://togithub.com/adriansmares) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - Add openapiv2\_opt support for passing values to go templates via cli by [@​500poundbear](https://togithub.com/500poundbear) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - \[Bug [#​3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)] \[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when generating ope… by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - feat: partial message created as named definitions by [@​nkcr](https://togithub.com/nkcr) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) - Fix name tags in methods by [@​omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3843](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3843) - Revert [`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc) by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3856](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3856) #### New Contributors - [@​leungster](https://togithub.com/leungster) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - [@​adriansmares](https://togithub.com/adriansmares) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - [@​500poundbear](https://togithub.com/500poundbear) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - [@​omrikiei](https://togithub.com/omrikiei) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - [@​nkcr](https://togithub.com/nkcr) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) **Full Changelog**: grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0 </details> <details> <summary>golang/go (go)</summary> ### [`v1.21.6`](https://togithub.com/golang/go/compare/go1.21.5...go1.21.6) </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.32.0`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.32.0) [Compare Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.31.0...v1.32.0) **Full Changelog**: protocolbuffers/protobuf-go@v1.31.0...v1.32.0 This release contains commit protocolbuffers/protobuf-go@bfcd647, which fixes a denial of service vulnerability by preventing a stack overflow through a default maximum recursion limit. See [https://github.com/golang/protobuf/issues/1583](https://togithub.com/golang/protobuf/issues/1583) and [https://github.com/golang/protobuf/issues/1584](https://togithub.com/golang/protobuf/issues/1584) for details. </details> <details> <summary>jekyll/jekyll-feed (jekyll-feed)</summary> ### [`v0.17.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0170--2022-10-14) [Compare Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.16.0...v0.17.0) ##### Documentation - Update CI status badge ([#​363](https://togithub.com/jekyll/jekyll-feed/issues/363)) ##### Development Fixes - Add Ruby 3.1 to the CI matrix ([#​365](https://togithub.com/jekyll/jekyll-feed/issues/365)) ##### Minor Enhancements - Allow disabling of jekyll-feed while in development ([#​370](https://togithub.com/jekyll/jekyll-feed/issues/370)) ### [`v0.16.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0160--2022-01-03) [Compare Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.15.1...v0.16.0) ##### Minor Enhancements - Add support for `page.description` in front matter to become entry `<summary>` ([#​297](https://togithub.com/jekyll/jekyll-feed/issues/297)) ##### Bug Fixes - Fold private methods into the `:render` method as local variables ([#​327](https://togithub.com/jekyll/jekyll-feed/issues/327)) - Check `post.categories` instead of `post.category` ([#​357](https://togithub.com/jekyll/jekyll-feed/issues/357)) - Switched xml_escape for `<![CDATA[]]>` for post content ([#​332](https://togithub.com/jekyll/jekyll-feed/issues/332)) ##### Development Fixes - Add Ruby 3.0 to CI ([#​337](https://togithub.com/jekyll/jekyll-feed/issues/337)) - Lock RuboCop to v1.18.x ([#​348](https://togithub.com/jekyll/jekyll-feed/issues/348)) - Add workflow to release gem via GH Action ([#​355](https://togithub.com/jekyll/jekyll-feed/issues/355)) ##### Documentation - Use `.atom` extension in documented examples since we write an Atom feed ([#​359](https://togithub.com/jekyll/jekyll-feed/issues/359)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
cparkins
referenced
this pull request
in AmadeusITGroup/opentelemetry-collector-contrib
Jan 10, 2024
… v2.19.0 (open-telemetry#30353) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | `v2.18.1` -> `v2.19.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc-ecosystem/grpc-gateway (github.com/grpc-ecosystem/grpc-gateway/v2)</summary> ### [`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0) #### What's Changed - fix: use req.Body instead of IOReaderFactory when possible by [@&open-telemetry#8203;leungster](https://togithub.com/leungster) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - runtime: Add outgoing trailer matching by [@&open-telemetry#8203;adriansmares](https://togithub.com/adriansmares) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - Add openapiv2\_opt support for passing values to go templates via cli by [@&open-telemetry#8203;500poundbear](https://togithub.com/500poundbear) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - \[Bug [#&open-telemetry#8203;3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)] \[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when generating ope… by [@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - feat: partial message created as named definitions by [@&open-telemetry#8203;nkcr](https://togithub.com/nkcr) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) - Fix name tags in methods by [@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3843](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3843) - Revert [`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc) by [@&open-telemetry#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3856](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3856) #### New Contributors - [@&open-telemetry#8203;leungster](https://togithub.com/leungster) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3727](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3727) - [@&open-telemetry#8203;adriansmares](https://togithub.com/adriansmares) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3725](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3725) - [@&open-telemetry#8203;500poundbear](https://togithub.com/500poundbear) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3764](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3764) - [@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3830](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3830) - [@&open-telemetry#8203;nkcr](https://togithub.com/nkcr) made their first contribution in [https://github.com/grpc-ecosystem/grpc-gateway/pull/3743](https://togithub.com/grpc-ecosystem/grpc-gateway/pull/3743) **Full Changelog**: grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code that references the name attribute in the openapiv2 tag attribute.
References to other Issues or PRs
Fixes #3829 issue in the aspect of method tags
References to other Issues or PRs
continuation of PR 3830
Have you read the Contributing Guidelines? yes
Brief description of what is fixed or changed
when generating method documentation, use the service name tag instead of the service name if possible
Summary by CodeRabbit
New Features
namefield.Refactor
Bug Fixes
Documentation