-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use StreamErrorHandler to send back invalid argument error in bidirectional streaming #4864
feat: use StreamErrorHandler to send back invalid argument error in bidirectional streaming #4864
Conversation
…idirectional streaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, this makes sense to me!
ea65295
to
2b48c69
Compare
5bb2105
to
71053cc
Compare
71053cc
to
7bd4ec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I love this test!
6599679
to
c05b3bc
Compare
c05b3bc
to
1bf22c6
Compare
Thanks for the contribution! |
Hey Johan, curious if there will be a release soon, or is it something that I have to initiate following the instructions in CONTRIBUTION.md? |
I'm planning a release soon, yeah, but there's another change in progress that I want to get in first: #4866 |
References to other Issues or PRs
Fixes #4795
follow up to #4819
Have you read the Contributing Guidelines?
yes
Brief description of what is fixed or changed
Use StreamErrorHandler instead of ErrorHandler for sending back invalid request errors.
Other comments
taking inspiration from handleForwardResponseStreamError
can add some unit tests if looks good overall