Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce number of empty lines in generated code #4965

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

This PR group vars and reduces the number of empty lines in generated code

@mmorel-35 mmorel-35 force-pushed the template/empty-lines branch from 79f113b to 055254b Compare November 19, 2024 14:19
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks like we might need to update some tests too. This is a pretty big change but hopefully the generated file corpus we have should catch any errors.

@mmorel-35 mmorel-35 force-pushed the template/empty-lines branch 3 times, most recently from 16183d1 to af0cb63 Compare November 19, 2024 22:41
@mmorel-35 mmorel-35 force-pushed the template/empty-lines branch 2 times, most recently from cca3144 to 0ebb17a Compare November 19, 2024 23:21
@mmorel-35 mmorel-35 force-pushed the template/empty-lines branch from 0ebb17a to 10fb401 Compare November 19, 2024 23:22
@johanbrandhorst johanbrandhorst merged commit 7cffabd into grpc-ecosystem:main Nov 20, 2024
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants