Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Relax the minimum required go version #5022

Conversation

nhhagen
Copy link
Contributor

@nhhagen nhhagen commented Dec 5, 2024

Setting the go directive to a patch version above .0 causes issues for downstream code bases that have their go directive set to the .0 patch version of Go.

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

Setting the `go` directive to a patch version above `.0` causes issues
for downstream code bases that have their `go` directive set to the `.0`
patch version of Go.
@nhhagen
Copy link
Contributor Author

nhhagen commented Dec 5, 2024

A similar issue has been discussed in grpc/grpc-go#7624 (comment)

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see what CI thinks.

go 1.22.7

toolchain go1.23.4
go 1.22.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, we only updated the version because gRPC updated their version. I expect we won't be able to merge this until there's a new tagged gRPC version with the relaxed Go constraint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gRPC release a new version relaxing the version requirement https://github.com/grpc/grpc-go/releases/tag/v1.68.1. This was merged in #5018.

@johanbrandhorst johanbrandhorst merged commit a954494 into grpc-ecosystem:main Dec 5, 2024
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@nhhagen
Copy link
Contributor Author

nhhagen commented Dec 5, 2024

You are welcome, solved an internal issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants