Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use org_golang_x_tools as module extension #5043

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented Dec 10, 2024

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

If not using module dependencies, there is a risk of including the same dependency twice as Bzlmod cannot resolve this correctly.

Other comments

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you

@johanbrandhorst
Copy link
Collaborator

Looks like we need to rerun gazelle?

@mering
Copy link
Contributor Author

mering commented Dec 10, 2024

Oops, I forgot to update the lock file. Should be fixed now.

@johanbrandhorst johanbrandhorst enabled auto-merge (squash) December 10, 2024 17:09
@johanbrandhorst
Copy link
Collaborator

Looks like there still a minor lockfile issue

@mering
Copy link
Contributor Author

mering commented Dec 10, 2024

How do you update the lockfile correctly? We are not using lockfiles yet.

auto-merge was automatically disabled December 10, 2024 17:30

Head branch was pushed to by a user without write access

@mering
Copy link
Contributor Author

mering commented Dec 10, 2024

I just ran bazel run //:gazelle as the CI. Let's see if this fixes it.

@johanbrandhorst johanbrandhorst enabled auto-merge (squash) December 10, 2024 17:53
@johanbrandhorst johanbrandhorst merged commit 5e3fd79 into grpc-ecosystem:main Dec 10, 2024
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@mering mering deleted the x-tools-go-mod branch December 16, 2024 11:21
@mering mering restored the x-tools-go-mod branch December 16, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants