Fix travis to only difftest on go 1.9 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go master contains the commit hash that it was built at (or some similar token). Unfortunately our regexp that we were checking against had an escaping error. `grep -q 1.9` instead of `grep -q 1\.9` which meant it was matching 1[any character]2. The current golang master commit is "go version devel +15bc0a129a Wed Jan 3 04:34:11 2018 +0000 linux/amd64" Fixes by making the string A LOT more specific and escaping.
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go master contains the commit hash that it was built at (or some similar
token). Unfortunately our regexp that we were checking against had an
escaping error.
grep -q 1.9instead ofgrep -q 1\.9which meant itwas matching 1[any character]2. The current golang master commit is
"go version devel +15bc0a129a Wed Jan 3 04:34:11 2018 +0000 linux/amd64"
Fixes by making the string A LOT more specific and escaping.