Support for map type in query string #535
Conversation
adamstruck
force-pushed
the
map-query-params
branch
from
ca54f61 to
6e5fd3d
Compare
runtime/query.go
Outdated
| @@ -84,6 +94,11 @@ func populateFieldValueFromPath(msg proto.Message, fieldPath []string, values [] | |||
| case reflect.Struct: | |||
| m = f | |||
| continue | |||
| case reflect.Map: | |||
| if !isLast { | |||
| return fmt.Errorf("unexpected map field in %s", strings.Join(fieldPath, ".")) | |||
There was a problem hiding this comment.
Can you elaborate in this error message. As I understand it the conern here is that you could make the querystring ?foo[bar] which doesn't have a value. Could you add a remark about what was expected and why this is an error condition?
There was a problem hiding this comment.
This is to handle the case where an intermediate field in fieldPath refers to a map.
i.e. obj.nested.map_field.foo where map_field is a map.
There was a problem hiding this comment.
Could you enhance the error message to reflect that intent?
There was a problem hiding this comment.
sure no problem.
runtime/query_test.go
Outdated
| "map_value12[key]": {"2.5"}, | ||
| "map_value13[2.5]": {"value"}, | ||
| "map_value14[key]": {"true"}, | ||
| "map_value15[true]": {"value"}, |
There was a problem hiding this comment.
Can you add some examples where you populate multiple map values at the same time?
adamstruck
force-pushed
the
map-query-params
branch
from
6e5fd3d to
9c3146c
Compare
adamstruck
force-pushed
the
map-query-params
branch
from
9c3146c to
1abcd3a
Compare
|
Thanks for the feedback! I think my latest commit addresses your comments. |
|
Thanks for the new feature and thanks for contributing! |
Adds support for the map type in query strings. Filter strings take the form:
?map_field[key]=value.Only maps with primitive keys and values are supported.
Closes #316