Regenerate .pb.go code using the new Go protobuf package. #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on why only the build configuration Go 1.10.x without request_context plugin flag would be failing here? @achew22 EDIT: I've hit retry, let's see if it goes through. |
|
@ivucica I think I've fixed the underlying problem, but there might be more that you've noticed. Can you try at HEAD? |
ivucica
force-pushed
the
ivucica-regenerate-pb
branch
from
c6bb817 to
4b86305
Compare
|
I've rebased on HEAD, let's see if the tests go through now! |
There have been incompatible changes in the underlying package, breaking at least the OpenAPIv2 generator. See https://groups.google.com/forum/#!topic/golang-nuts/F5xFHTfwRnY. This commit is obsoleted by #656
ivucica
force-pushed
the
ivucica-regenerate-pb
branch
from
4b86305 to
c4ae565
Compare
|
I just saw #656. Thanks, let's close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been incompatible changes in the underlying package, breaking at
least the OpenAPIv2 generator.
See https://groups.google.com/forum/#!topic/golang-nuts/F5xFHTfwRnY.
I did not run the tests locally, as I don't have a functioning setup of swagger codegen. I'll instead wait for the CI to complete, fix any problems and only spend time on setting it up locally if needed.
I regenerated the
.pb.gofiles by just runningmake test.