Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-protoc was checking version from wrong executable path #721

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

temoto
Copy link
Contributor

@temoto temoto commented Aug 9, 2018

Thanks for install-protoc script, I copied it to my project.

@codecov-io
Copy link

Codecov Report

Merging #721 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   56.16%   55.83%   -0.34%     
==========================================
  Files          30       30              
  Lines        3112     3161      +49     
==========================================
+ Hits         1748     1765      +17     
- Misses       1193     1223      +30     
- Partials      171      173       +2
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/descriptor/registry.go 68.06% <0%> (-2.98%) ⬇️
runtime/handler.go 41.6% <0%> (-1.74%) ⬇️
protoc-gen-grpc-gateway/descriptor/services.go 73.97% <0%> (-1.57%) ⬇️
protoc-gen-swagger/main.go 27.05% <0%> (-0.33%) ⬇️
runtime/mux.go 44.16% <0%> (ø) ⬆️
protoc-gen-grpc-gateway/descriptor/types.go 49.07% <0%> (ø) ⬆️
protoc-gen-swagger/genswagger/template.go 38.99% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221ef34...925ebf0. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit c30b7d6 into grpc-ecosystem:master Aug 29, 2018
@temoto temoto deleted the patch-1 branch August 29, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants