-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for more WKT #816
Added support for more WKT #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! I don't think we need to add the greeter server or greeter proxy since we can't run those in CI (at least not right now). Otherwise looks good!
@johanbrandhorst Right. Removed those. |
It looks like the generated files don't build, can you see if we can fix the signature of the new functions? |
This is great, thanks! I will merge once the build has finished successfully :). |
Oops, looks like the Bazel files are out of date: https://circleci.com/gh/grpc-ecosystem/grpc-gateway/736. Could you run the following command to update everything please? $ docker run -itv $(pwd):/grpc-gateway -w /grpc-gateway --entrypoint /bin/bash --rm \
l.gcr.io/google/bazel -c 'bazel run :gazelle_fix; bazel run :buildifier' |
On a sidenote: @drigz, how often will unrelated user PRs be failing like this? Is there some way we can just update these manually and not have it fail the build? |
@johanbrandhorst Created #817 to avoid noise on this PR. |
That bazel fix command is really impressive, wow! I'll merge this once the build finishes :). |
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 53.3% 52.89% -0.41%
==========================================
Files 30 30
Lines 3371 3397 +26
==========================================
Hits 1797 1797
- Misses 1399 1425 +26
Partials 175 175
Continue to review full report at Codecov.
|
Agree. It finished smoothly though it took really long. I felt there should be easier way so I don't have to download heavy docker images. Maybe use multistage build. idk. just thinking out loud. |
Thank you for your contribution! |
No problem @johanbrandhorst . I'm using it for one of my work item. So I had to make it work anyway. |
* Added support for more WKT * Lint fix: added comments on exported functions * Lint fix: added comments on exported functions * Added end to end example to show support of StringValue in url option template * updated more example protos; removed server and proxy for now * Updated convert.go to fix float and other wkt * brazel build fix
Adding support for more well known types.
Adding support for wrappers (google.protbuf.wrappers)
Adding Example for using StringValue protobuf wrapper in url template option
Should fix: #808